#3414: Configured setting for displaying total review score on reviews page #3415
Conversation
gmurtaza00
force-pushed
the
configure-displaying-total-review-score
branch
from
65974ad
to
431833b
Compare
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
There was a problem hiding this comment.
Looks good to me. As it won't affect the current visibility so there shouldn't be any issue but I was thinking to use these kinds of settings as wagtail settings so that these can be tested and changeable easily by any organization.
What do you think @gmurtaza00 @frjo @theskumar?
hypha/settings/base.py
Outdated
| @@ -478,3 +478,5 @@ | |||
| debug=SENTRY_DEBUG, | |||
| integrations=[DjangoIntegration()] | |||
| ) | |||
|
|
|||
| DISPLAY_TOTAL_REVIEW_SCORE = env.bool('DISPLAY_TOTAL_REVIEW_SCORE', default = False) | |||
There was a problem hiding this comment.
This should be moved up to the Hypa settings section. We want all Hypha settings together in one place.
|
We want to move a lot of settings in to a Hypha settings section in the Web app. I think we need to decide how that is going to work overall first. |
|
|
||
| If True sum of scores will be displayed otherwise average of scores will be displayed | ||
|
|
||
| DISPLAY_TOTAL_REVIEW_SCORE = env.bool('DISPLAY_TOTAL_REVIEW_SCORE', default = False) |
There was a problem hiding this comment.
Make it an option instead of boolean. Current boolean make a lot of implicit assumption. It's a either/or situation but not reflected well with the name of the variable.
Make this setting a take a value, and have it also accept empty for use-cases where no final summary is desired by any setup.
Suggestion:
from typing import Literal
REVIEWS_FINAL_SCORE_METHOD: Literal['sum', 'avg', ''] = env.str('REVIEWS_SUMMARY_METHOD', default='sum')
There was a problem hiding this comment.
@theskumar For cases like empty string, should we return NA from calculate_score function?
There was a problem hiding this comment.
None or NA seems fine with me.
Configured a setting for displaying total review score instead of average score. Each organization can customize it accordingly.
Setting to consider:
DISPLAY_TOTAL_REVIEW_SCORECloses #3414