-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#3417: Configured default visibility for review #3418
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frjo
requested changes
May 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just rename the setting and move it up a bit in base.py.
frjo
approved these changes
May 19, 2023
sandeepsajan0
approved these changes
May 31, 2023
frjo
force-pushed
the
configure-default-visibility-for-review
branch
from
December 14, 2023 13:43
63b6f35
to
83de439
Compare
frjo
added
Type: Enhancement
This is an improvement of an existing thing (not a new thing, which would be a feature).
Type: Patch
Mini change, used in release drafter
labels
Dec 14, 2023
@theskumar Any issues with this one? |
Looks good to me. |
frjo
force-pushed
the
configure-default-visibility-for-review
branch
from
December 15, 2023 08:08
22df8f4
to
9f851dc
Compare
wes-otf
added
Status: Tested - approved for live ✅
and removed
Status: Needs testing
Tickets that need testing/qa
labels
Dec 15, 2023
wes-otf
pushed a commit
that referenced
this pull request
May 7, 2024
Configured setting for default visibility of review. It can be set as **private** or **reviewers**. - Private: Visible only to staff. - Reviewers: Visible to other reviewers and staff. **Setting to consider:** - ```REVIEW_VISIBILITY_DEFAULT ``` Closes #3417 --------- Co-authored-by: Fredrik Jonsson <frjo@xdeb.org>
wes-otf
pushed a commit
that referenced
this pull request
May 8, 2024
Configured setting for default visibility of review. It can be set as **private** or **reviewers**. - Private: Visible only to staff. - Reviewers: Visible to other reviewers and staff. **Setting to consider:** - ```REVIEW_VISIBILITY_DEFAULT ``` Closes #3417 --------- Co-authored-by: Fredrik Jonsson <frjo@xdeb.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Status: Tested - approved for live ✅
Type: Enhancement
This is an improvement of an existing thing (not a new thing, which would be a feature).
Type: Patch
Mini change, used in release drafter
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configured setting for default visibility of review. It can be set as private or reviewers.
Setting to consider:
REVIEW_VISIBILITY_DEFAULT
Closes #3417