Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3417: Configured default visibility for review #3418

Merged
merged 3 commits into from
Dec 18, 2023

Conversation

gmurtaza00
Copy link
Contributor

@gmurtaza00 gmurtaza00 commented May 18, 2023

Configured setting for default visibility of review. It can be set as private or reviewers.

  • Private: Visible only to staff.
  • Reviewers: Visible to other reviewers and staff.

Setting to consider:

  • REVIEW_VISIBILITY_DEFAULT

Closes #3417

@gmurtaza00 gmurtaza00 requested review from frjo and theskumar May 18, 2023 16:44
@gmurtaza00 gmurtaza00 self-assigned this May 18, 2023
Copy link
Contributor

@frjo frjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just rename the setting and move it up a bit in base.py.

hypha/settings/base.py Outdated Show resolved Hide resolved
@frjo frjo force-pushed the configure-default-visibility-for-review branch from 63b6f35 to 83de439 Compare December 14, 2023 13:43
@frjo frjo added Type: Enhancement This is an improvement of an existing thing (not a new thing, which would be a feature). Type: Patch Mini change, used in release drafter labels Dec 14, 2023
@frjo
Copy link
Contributor

frjo commented Dec 14, 2023

@theskumar Any issues with this one?

@theskumar
Copy link
Member

Looks good to me.

@frjo frjo force-pushed the configure-default-visibility-for-review branch from 22df8f4 to 9f851dc Compare December 15, 2023 08:08
@frjo frjo added the Status: Needs testing Tickets that need testing/qa label Dec 15, 2023
@wes-otf wes-otf added Status: Tested - approved for live ✅ and removed Status: Needs testing Tickets that need testing/qa labels Dec 15, 2023
@frjo frjo merged commit f790dc8 into main Dec 18, 2023
10 checks passed
@frjo frjo deleted the configure-default-visibility-for-review branch February 12, 2024 11:46
wes-otf pushed a commit that referenced this pull request May 7, 2024
Configured setting for default visibility of review. It can be set as
**private** or **reviewers**.

- Private: Visible only to staff.
- Reviewers: Visible to other reviewers and staff.

**Setting to consider:**

- ```REVIEW_VISIBILITY_DEFAULT ```

Closes #3417

---------

Co-authored-by: Fredrik Jonsson <frjo@xdeb.org>
wes-otf pushed a commit that referenced this pull request May 8, 2024
Configured setting for default visibility of review. It can be set as
**private** or **reviewers**.

- Private: Visible only to staff.
- Reviewers: Visible to other reviewers and staff.

**Setting to consider:**

- ```REVIEW_VISIBILITY_DEFAULT ```

Closes #3417

---------

Co-authored-by: Fredrik Jonsson <frjo@xdeb.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Tested - approved for live ✅ Type: Enhancement This is an improvement of an existing thing (not a new thing, which would be a feature). Type: Patch Mini change, used in release drafter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure default visibility for review
5 participants