Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code-style using 'pre-commit run --all-files' #3547

Merged
merged 3 commits into from
Sep 8, 2023
Merged

Conversation

theskumar
Copy link
Member

@theskumar theskumar commented Aug 31, 2023

Add black and prettier check to lint

Install the git hook in your local repo with:

pre-commit install

Check and fixes will then be done on each commit. Never get a lint warning again!

@theskumar theskumar self-assigned this Aug 31, 2023
<a href="{{ url }}" target="_blank" class="feed__related-item">
{% trans "View " %}{{ activity.related_object|model_verbose_name }} <svg class="icon"><use xlink:href="#arrow-head-pixels--solid"></use></svg>
</a>
<a href="{{ url }}" target="_blank" class="feed__related-item">

Check warning

Code scanning / CodeQL

Potentially unsafe external link Medium

External links without noopener/noreferrer are a potential security risk.
@frjo frjo changed the title Update code-style using 'precommit run --all-files' Update code-style using 'pre-commit run --all-files' Aug 31, 2023
Copy link
Contributor

@frjo frjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just added a missing hyphen to the command in the title.

@theskumar theskumar force-pushed the refractor/code-style branch 4 times, most recently from 0fea450 to ab7c4ca Compare September 8, 2023 08:18
@frjo frjo added Type: Maintenance Type: Minor Minor change, used in release drafter labels Sep 8, 2023
@frjo frjo merged commit 53ed252 into main Sep 8, 2023
10 checks passed
@theskumar theskumar deleted the refractor/code-style branch September 8, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Type: Minor Minor change, used in release drafter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants