Break title in max three lines with expandable on hover #3654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
theskumar
requested changes
Nov 15, 2023
hypha/apply/dashboard/templates/dashboard/applicant_dashboard.html
Outdated
Show resolved
Hide resolved
hypha/apply/dashboard/templates/dashboard/applicant_dashboard.html
Outdated
Show resolved
Hide resolved
sandeepsajan0
force-pushed
the
enhancement/gh-3631-title-ui
branch
2 times, most recently
from
79ef9ce
to
2ed2265
Compare
|
@sandeepsajan0 Are you able to resolve the conflict? |
sandeepsajan0
force-pushed
the
enhancement/gh-3631-title-ui
branch
from
2ed2265
to
53d88a8
Compare
|
@frjo It is ready for testing. |
frjo
added
Type: Enhancement
sandeepsajan0
changed the title
|
In testing it looked like the mobile alignment was still a little off as mentioned by @theskumar. Other than that everything worked as intended and was ready for live!
|
|
Sounds good! This is ready to go then. |
wes-otf
added
Status: Tested - approved for live ✅
and removed
Status: Needs testing
wes-otf
pushed a commit
that referenced
this pull request
May 7, 2024
wes-otf
pushed a commit
that referenced
this pull request
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3631
Right now, big titles look like this on the applicant dashboard:
It looks like this after the fix:
On large screen/laptop:
on hover(above screen):
For smaller screen like tablet/ipad mini:
