Remove dependency of invoice delete on PROJECT_ENABLED Flag #3690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the PROJECT_ENABLED=False then the invoice should not be created at the first place. But somehow at some point projects where enabled and there are project and invoices in the system. The system should function as expected compared to lacking functionality in/between. This PR remove the PROJECT_ENABLED check on the project's get_absolute_url, which is used while deleting invoices or potentially at the other places. closes #3663
frjo
added
Type: Bug
wes-otf
approved these changes
Dec 11, 2023
frjo
approved these changes
Dec 13, 2023
wes-otf
added
Status: Tested - approved for live ✅
and removed
Status: Needs testing
wes-otf
pushed a commit
that referenced
this pull request
May 7, 2024
If the PROJECT_ENABLED=False then the invoice should not be created at the first place. But somehow at some point projects where enabled and there are project and invoices in the system. The system should function as expected compared to lacking functionality in/between. This PR remove the PROJECT_ENABLED check on the project's get_absolute_url, which is used while deleting invoices or potentially at the other places. closes #3663
wes-otf
pushed a commit
that referenced
this pull request
May 8, 2024
If the PROJECT_ENABLED=False then the invoice should not be created at the first place. But somehow at some point projects where enabled and there are project and invoices in the system. The system should function as expected compared to lacking functionality in/between. This PR remove the PROJECT_ENABLED check on the project's get_absolute_url, which is used while deleting invoices or potentially at the other places. closes #3663
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the PROJECT_ENABLED=False then the invoice should not be created at
the first place. But somehow at some point projects where enabled and
there are project and invoices in the system. The system should function
as expected compared to lacking functionality in/between.
This PR remove the PROJECT_ENABLED check on the project's
get_absolute_url, which is used while deleting invoices or potentially
at the other places.
closes #3663