-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove social media sharing, part of public site removal #3710
Conversation
theskumar
commented
Jan 7, 2024
- Removes the SocialFields and SocialMediaSettings Model
- Esp. removes any twitter, fb or per page images/text
577749d
to
62b71ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to get rid of this. I merge the logo/favicon PR so I created a minor merge conflict for you.
#: hypha/templates/includes/share.html:21 | ||
msgid "Share on Facebook" | ||
msgstr "" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is auto generated, better to update in a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, but can we get this merged and i'll take care of in the future PRs.
- Removes the SocialFields and SocialMediaSettings Model - Esp. removes any twitter, fb or per page images/text
62b71ec
to
96cfdff
Compare
Resolved conflicts, please take another look. |
- Removes the SocialFields and SocialMediaSettings Model - Esp. removes any twitter, fb or per page images/text
- Removes the SocialFields and SocialMediaSettings Model - Esp. removes any twitter, fb or per page images/text