Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove social media sharing, part of public site removal #3710

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

theskumar
Copy link
Member

  • Removes the SocialFields and SocialMediaSettings Model
  • Esp. removes any twitter, fb or per page images/text

@theskumar theskumar self-assigned this Jan 7, 2024
@theskumar theskumar requested review from frjo and wes-otf January 7, 2024 18:49
@theskumar theskumar force-pushed the maintainance/remove-public-social-media branch from 577749d to 62b71ec Compare January 7, 2024 18:54
Copy link
Contributor

@frjo frjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to get rid of this. I merge the logo/favicon PR so I created a minor merge conflict for you.

#: hypha/templates/includes/share.html:21
msgid "Share on Facebook"
msgstr ""

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is auto generated, better to update in a separate PR.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, but can we get this merged and i'll take care of in the future PRs.

- Removes the SocialFields and SocialMediaSettings Model
- Esp. removes any twitter, fb or per page images/text
@theskumar theskumar force-pushed the maintainance/remove-public-social-media branch from 62b71ec to 96cfdff Compare January 9, 2024 12:37
@theskumar
Copy link
Member Author

Resolved conflicts, please take another look.

@theskumar theskumar requested a review from frjo January 9, 2024 12:43
@frjo frjo merged commit 52df52b into main Jan 9, 2024
10 checks passed
@frjo frjo added Type: Maintenance Type: Patch Mini change, used in release drafter labels Jan 9, 2024
@theskumar theskumar deleted the maintainance/remove-public-social-media branch February 7, 2024 11:05
wes-otf pushed a commit that referenced this pull request May 7, 2024
- Removes the SocialFields and SocialMediaSettings Model
- Esp. removes any twitter, fb or per page images/text
wes-otf pushed a commit that referenced this pull request May 8, 2024
- Removes the SocialFields and SocialMediaSettings Model
- Esp. removes any twitter, fb or per page images/text
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Type: Patch Mini change, used in release drafter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants