Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix footer display on the htmx rendered pages #3764

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Fix footer display on the htmx rendered pages #3764

merged 1 commit into from
Feb 9, 2024

Conversation

theskumar
Copy link
Member

Description

This fixes the partial html returned to replace the

section, adds flex grow so that the footer div sticks to the bottom on the pages with less content.

Screenshot 2024-02-09 at 3  21 01@2x

Test Steps

  • on a relatively big screen, use passwordless login
  • After email is submitted, the server returns just the content, ensure the footer sticks to the bottom and not mid-way of the page

@frjo frjo added Type: Enhancement This is an improvement of an existing thing (not a new thing, which would be a feature). Type: Patch Mini change, used in release drafter labels Feb 9, 2024
@frjo frjo merged commit 6c8a914 into main Feb 9, 2024
10 checks passed
@theskumar theskumar deleted the fix/footer-alignment-htmx branch February 9, 2024 17:54
wes-otf pushed a commit that referenced this pull request May 7, 2024
@theskumar @wes-otf
Fix footer display on the htmx rendered pages (#3764)
f37e176 
This fixes the partial html returned to replace the <main> section, adds
flex `grow` so that the footer div sticks to the bottom on the pages
with less content.
wes-otf pushed a commit that referenced this pull request May 8, 2024
@theskumar @wes-otf
Fix footer display on the htmx rendered pages (#3764)
5d5d144 
This fixes the partial html returned to replace the <main> section, adds
flex `grow` so that the footer div sticks to the bottom on the pages
with less content.
Vldln pushed a commit to equalitie/hypha that referenced this pull request May 28, 2024
@theskumar
Fix footer display on the htmx rendered pages (HyphaApp#3764)
7f078e8 
This fixes the partial html returned to replace the <main> section, adds
flex `grow` so that the footer div sticks to the bottom on the pages
with less content.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frjo frjo Awaiting requested review from frjo

@wes-otf wes-otf Awaiting requested review from wes-otf

Assignees
No one assigned
Labels
Type: Enhancement This is an improvement of an existing thing (not a new thing, which would be a feature). Type: Patch Mini change, used in release drafter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@theskumar @frjo