Move systemsettings out of public + remove duplicate 404/403 template #3804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wes-otf
approved these changes
Mar 20, 2024
- Renamed the SystemSettings model class - 404/403 templates specific to apply to is removed, use a single template for them. - Add data migration for old SystemMessageSettings model class
frjo
force-pushed
the
move-system-message-settings
branch
from
21f761a
to
8ea3bb3
Compare
frjo
added
Status: Needs testing
wes-otf
added
Status: Tested - approved for live ✅
and removed
Status: Needs testing
wes-otf
pushed a commit
to OpenTechFund/apply-app
that referenced
this pull request
Apr 1, 2024
…HyphaApp#3804) - Renamed the SystemSettings model class - 404/403 templates specific to apply to is removed, use a single template for them. - Add data migration for old SystemMessageSettings model class - add/update the testing urls for error pages Fixes HyphaApp#3768
wes-otf
pushed a commit
to OpenTechFund/apply-app
that referenced
this pull request
Apr 1, 2024
…HyphaApp#3804) - Renamed the SystemSettings model class - 404/403 templates specific to apply to is removed, use a single template for them. - Add data migration for old SystemMessageSettings model class - add/update the testing urls for error pages Fixes HyphaApp#3768
Vldln
pushed a commit
to equalitie/hypha
that referenced
this pull request
May 28, 2024
…HyphaApp#3804) - Renamed the SystemSettings model class - 404/403 templates specific to apply to is removed, use a single template for them. - Add data migration for old SystemMessageSettings model class - add/update the testing urls for error pages Fixes HyphaApp#3768
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
template for them.
Fixes #3768
Test Steps
test400/,test403/,test404/,test500/andtest403_csrf/. Note, all of these pages had custom styles, this PR doesn't try to add new styles/messages for pages that where not already had custom implementation, just exposes these testing urls.