Swapped out hamburger menu for a Login button in mobile view
#3812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wes-otf
added
Type: Bug
theskumar
approved these changes
Mar 16, 2024
|
Looks good, happy to merge this. But when testing this I saw things we can improve in the overall login/signup flow/forms. See #3813 |
|
@frjo I totally agree. Should we merge this as a fix for the time being and hit a refactor next or did you want to handle this now? |
wes-otf
added a commit
to OpenTechFund/apply-app
that referenced
this pull request
Apr 1, 2024
…App#3812) Fixes HyphaApp#3811. This removes the hamburger menu for unauthenticated users in favor of a simple `Login` button. If a signup is intended and `ENABLE_PUBLIC_SIGNUP` is enabled on the instance, the signup button can be found on the `/auth/` view. I didn't want to overload the mobile view by putting login & signup next to eachother.
wes-otf
added a commit
to OpenTechFund/apply-app
that referenced
this pull request
Apr 1, 2024
…App#3812) Fixes HyphaApp#3811. This removes the hamburger menu for unauthenticated users in favor of a simple `Login` button. If a signup is intended and `ENABLE_PUBLIC_SIGNUP` is enabled on the instance, the signup button can be found on the `/auth/` view. I didn't want to overload the mobile view by putting login & signup next to eachother.
wes-otf
added a commit
that referenced
this pull request
May 7, 2024
Fixes #3811. This removes the hamburger menu for unauthenticated users in favor of a simple `Login` button. If a signup is intended and `ENABLE_PUBLIC_SIGNUP` is enabled on the instance, the signup button can be found on the `/auth/` view. I didn't want to overload the mobile view by putting login & signup next to eachother.
wes-otf
added a commit
that referenced
this pull request
May 8, 2024
Fixes #3811. This removes the hamburger menu for unauthenticated users in favor of a simple `Login` button. If a signup is intended and `ENABLE_PUBLIC_SIGNUP` is enabled on the instance, the signup button can be found on the `/auth/` view. I didn't want to overload the mobile view by putting login & signup next to eachother.
Vldln
pushed a commit
to equalitie/hypha
that referenced
this pull request
May 28, 2024
…App#3812) Fixes HyphaApp#3811. This removes the hamburger menu for unauthenticated users in favor of a simple `Login` button. If a signup is intended and `ENABLE_PUBLIC_SIGNUP` is enabled on the instance, the signup button can be found on the `/auth/` view. I didn't want to overload the mobile view by putting login & signup next to eachother.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3811. This removes the hamburger menu for unauthenticated users in favor of a simple
Loginbutton. If a signup is intended andENABLE_PUBLIC_SIGNUPis enabled on the instance, the signup button can be found on the/auth/view. I didn't want to overload the mobile view by putting login & signup next to eachother.Test Steps
Testing no burger menu when not logged in
Loginbutton appears in the top rightTesting burger menu for logged in users