Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the lazy load time for applicant submission on dashboard #3815

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

theskumar
Copy link
Member

Description

Right now, the my submission for the applicants on their dashboard is
loaded after 1s of page load which is too much delay.

This PR reduces the delay so it's the loading via htmx is triggered as
soon as the page is finished loading. Also, the PR reduces the loading
preview/skeleton to 3 so there is must of jumpiness before/after the
submissions are loading, this is based on the fact that on an average
there we only few submission by a single applicant.

Test Steps

  • Login as applicant
  • Notice the difference in the loading of "My submission" section, it should be much after now

Right now, the my submission for the applicants on their dashboard is
loaded after 1s of page load which is too much delay.

This PR reduces the delay so it's the loading via htmx is triggered as
soon as the page is finished loading. Also, the PR reduces the loading
preview/skeleton to 3 so there is must of jumpiness before/after the
submissions are loading, this is based on the fact that on an average
there we only few submission by a single applicant.
@theskumar theskumar self-assigned this Mar 19, 2024
@wes-otf
Copy link
Contributor

wes-otf commented Mar 20, 2024

This is great, all for a speedier load! Just out of curiosity what's the historical context here? Why was it necessary to have the delay previously?

@theskumar
Copy link
Member Author

The load delay at other places is 50ms, just enough to let UI settle down a bit. Since the "My submission" section is at the top, removing the delay altogether is just fine here.

@frjo frjo added Type: Enhancement This is an improvement of an existing thing (not a new thing, which would be a feature). Type: Patch Mini change, used in release drafter labels Mar 21, 2024
@frjo frjo merged commit 2d395a8 into main Mar 21, 2024
10 checks passed
@theskumar theskumar deleted the fix/applicant-dashboard-loading branch March 21, 2024 18:40
wes-otf pushed a commit to OpenTechFund/apply-app that referenced this pull request Apr 1, 2024
…aApp#3815)

Right now, the my submission for the applicants on their dashboard is
loaded after 1s of page load which is too much delay.

This PR reduces the delay so it's the loading via htmx is triggered as
soon as the page is finished loading. Also, the PR reduces the loading
preview/skeleton to 3 so there is must of jumpiness before/after the
submissions are loading, this is based on the fact that on an average
there we only few submission by a single applicant.
wes-otf pushed a commit to OpenTechFund/apply-app that referenced this pull request Apr 1, 2024
…aApp#3815)

Right now, the my submission for the applicants on their dashboard is
loaded after 1s of page load which is too much delay.

This PR reduces the delay so it's the loading via htmx is triggered as
soon as the page is finished loading. Also, the PR reduces the loading
preview/skeleton to 3 so there is must of jumpiness before/after the
submissions are loading, this is based on the fact that on an average
there we only few submission by a single applicant.
wes-otf pushed a commit that referenced this pull request May 7, 2024
Right now, the my submission for the applicants on their dashboard is
loaded after 1s of page load which is too much delay.

This PR reduces the delay so it's the loading via htmx is triggered as
soon as the page is finished loading. Also, the PR reduces the loading
preview/skeleton to 3 so there is must of jumpiness before/after the
submissions are loading, this is based on the fact that on an average
there we only few submission by a single applicant.
wes-otf pushed a commit that referenced this pull request May 8, 2024
Right now, the my submission for the applicants on their dashboard is
loaded after 1s of page load which is too much delay.

This PR reduces the delay so it's the loading via htmx is triggered as
soon as the page is finished loading. Also, the PR reduces the loading
preview/skeleton to 3 so there is must of jumpiness before/after the
submissions are loading, this is based on the fact that on an average
there we only few submission by a single applicant.
Vldln pushed a commit to equalitie/hypha that referenced this pull request May 28, 2024
…aApp#3815)

Right now, the my submission for the applicants on their dashboard is
loaded after 1s of page load which is too much delay.

This PR reduces the delay so it's the loading via htmx is triggered as
soon as the page is finished loading. Also, the PR reduces the loading
preview/skeleton to 3 so there is must of jumpiness before/after the
submissions are loading, this is based on the fact that on an average
there we only few submission by a single applicant.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement This is an improvement of an existing thing (not a new thing, which would be a feature). Type: Patch Mini change, used in release drafter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants