-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce the lazy load time for applicant submission on dashboard #3815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, the my submission for the applicants on their dashboard is loaded after 1s of page load which is too much delay. This PR reduces the delay so it's the loading via htmx is triggered as soon as the page is finished loading. Also, the PR reduces the loading preview/skeleton to 3 so there is must of jumpiness before/after the submissions are loading, this is based on the fact that on an average there we only few submission by a single applicant.
frjo
approved these changes
Mar 19, 2024
wes-otf
approved these changes
Mar 20, 2024
This is great, all for a speedier load! Just out of curiosity what's the historical context here? Why was it necessary to have the delay previously? |
The load delay at other places is 50ms, just enough to let UI settle down a bit. Since the "My submission" section is at the top, removing the delay altogether is just fine here. |
frjo
added
Type: Enhancement
This is an improvement of an existing thing (not a new thing, which would be a feature).
Type: Patch
Mini change, used in release drafter
labels
Mar 21, 2024
wes-otf
pushed a commit
to OpenTechFund/apply-app
that referenced
this pull request
Apr 1, 2024
…aApp#3815) Right now, the my submission for the applicants on their dashboard is loaded after 1s of page load which is too much delay. This PR reduces the delay so it's the loading via htmx is triggered as soon as the page is finished loading. Also, the PR reduces the loading preview/skeleton to 3 so there is must of jumpiness before/after the submissions are loading, this is based on the fact that on an average there we only few submission by a single applicant.
wes-otf
pushed a commit
to OpenTechFund/apply-app
that referenced
this pull request
Apr 1, 2024
…aApp#3815) Right now, the my submission for the applicants on their dashboard is loaded after 1s of page load which is too much delay. This PR reduces the delay so it's the loading via htmx is triggered as soon as the page is finished loading. Also, the PR reduces the loading preview/skeleton to 3 so there is must of jumpiness before/after the submissions are loading, this is based on the fact that on an average there we only few submission by a single applicant.
wes-otf
pushed a commit
that referenced
this pull request
May 7, 2024
Right now, the my submission for the applicants on their dashboard is loaded after 1s of page load which is too much delay. This PR reduces the delay so it's the loading via htmx is triggered as soon as the page is finished loading. Also, the PR reduces the loading preview/skeleton to 3 so there is must of jumpiness before/after the submissions are loading, this is based on the fact that on an average there we only few submission by a single applicant.
wes-otf
pushed a commit
that referenced
this pull request
May 8, 2024
Right now, the my submission for the applicants on their dashboard is loaded after 1s of page load which is too much delay. This PR reduces the delay so it's the loading via htmx is triggered as soon as the page is finished loading. Also, the PR reduces the loading preview/skeleton to 3 so there is must of jumpiness before/after the submissions are loading, this is based on the fact that on an average there we only few submission by a single applicant.
Vldln
pushed a commit
to equalitie/hypha
that referenced
this pull request
May 28, 2024
…aApp#3815) Right now, the my submission for the applicants on their dashboard is loaded after 1s of page load which is too much delay. This PR reduces the delay so it's the loading via htmx is triggered as soon as the page is finished loading. Also, the PR reduces the loading preview/skeleton to 3 so there is must of jumpiness before/after the submissions are loading, this is based on the fact that on an average there we only few submission by a single applicant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Type: Enhancement
This is an improvement of an existing thing (not a new thing, which would be a feature).
Type: Patch
Mini change, used in release drafter
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Right now, the my submission for the applicants on their dashboard is
loaded after 1s of page load which is too much delay.
This PR reduces the delay so it's the loading via htmx is triggered as
soon as the page is finished loading. Also, the PR reduces the loading
preview/skeleton to 3 so there is must of jumpiness before/after the
submissions are loading, this is based on the fact that on an average
there we only few submission by a single applicant.
Test Steps