Handle hypothetical object size greater than 2^32B.

hypopg_relation_size wasn't careful when converting the number of blocks to bytes, as the result can overflow an int32. Per report from Jan Koßmann.
HypoPG · Feb 20, 2020 · b41bd64 · b41bd64
1 parent 8827086
commit b41bd64
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/CONTRIBUTORS.md b/CONTRIBUTORS.md
@@ -12,3 +12,4 @@ People who contributed to hypopg:
   * Joel Van Horn
   * Michael Lroll
   * Godwottery
+  * Jan Koßmann
diff --git a/hypopg_index.c b/hypopg_index.c
@@ -1500,7 +1500,7 @@ hypopg_relation_size(PG_FUNCTION_ARGS)
 		}
 	}
 
-	PG_RETURN_INT64(pages * BLCKSZ);
+	PG_RETURN_INT64(pages * 1.0L * BLCKSZ);
 }
 
 /*