Allow labelling of values drawn from data strategy #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexwlchan
reviewed
Jan 17, 2017
| @@ -49,6 +49,24 @@ def test(data): | |||
| assert 'Draw 2: 0' in result | |||
|
|
|||
|
|
|||
| def test_prints_labels_if_given_on_failure(): | |||
There was a problem hiding this comment.
I was going to ask if we need a test that labels aren’t printed when not specified, but I think that’s covered by the existing tests – since the fallback behaviour is not to print any labels, we’d notice if/when those tests broke.
|
👍 I like the feature. Pending docs change I'm happy to have it. |
inglesp
force-pushed
the
allow-labelling-of-values-drawn-from-data-strategy
branch
from
a4148d0
to
51b3c72
Compare
|
OK, docs updated. |
DRMacIver
approved these changes
Feb 10, 2017
|
Sorry, I didn't mean to drop this. I'm happy with this as is, but it needs reformatting ("make format" should fix it followed by "make lint" to check if it did) to make the build pass. Can you do that and then rebase off master and then I'm totally happy to merge. |
This results in more useful output in falsifying examples
inglesp
force-pushed
the
allow-labelling-of-values-drawn-from-data-strategy
branch
from
51b3c72
to
f3d174b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This results in more useful output in falsifying examples.
If you're happy with this I can update the documentation.