Skip to content

Commit

Permalink
Merge pull request #2040 from HypothesisWorks/DRMacIver/new-shrink-steps
Browse files Browse the repository at this point in the history
New representation of shrink steps
  • Loading branch information
DRMacIver committed Jul 29, 2019
2 parents 166ef4d + 76a6463 commit 4ba856e
Show file tree
Hide file tree
Showing 5 changed files with 460 additions and 368 deletions.
5 changes: 5 additions & 0 deletions hypothesis-python/RELEASE.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
RELEASE_TYPE: patch

This release changes how the shrinker represents its progress internally. For large generated test cases
this should result in significantly less memory usage and possibly faster shrinking. Small generated
test cases may be slightly slower to shrink but this shouldn't be very noticeable.
145 changes: 145 additions & 0 deletions hypothesis-python/src/hypothesis/internal/conjecture/choicetree.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,145 @@
# coding=utf-8
#
# This file is part of Hypothesis, which may be found at
# https://github.com/HypothesisWorks/hypothesis/
#
# Most of this work is copyright (C) 2013-2019 David R. MacIver
# (david@drmaciver.com), but it contains contributions by others. See
# CONTRIBUTING.rst for a full list of people who may hold copyright, and
# consult the git log if you need to determine who owns an individual
# contribution.
#
# This Source Code Form is subject to the terms of the Mozilla Public License,
# v. 2.0. If a copy of the MPL was not distributed with this file, You can
# obtain one at https://mozilla.org/MPL/2.0/.
#
# END HEADER

from __future__ import absolute_import, division, print_function

from collections import defaultdict

from hypothesis.internal.compat import hrange


class Chooser(object):
"""A source of nondeterminism for use in shrink passes."""

def __init__(self, tree, prefix):
self.__prefix = prefix
self.__tree = tree
self.__node_trail = [tree.root]
self.__choices = []
self.__finished = False

def choose(self, values, condition=lambda x: True):
"""Return some element of values satisfying the condition
that will not lead to an exhausted branch, or raise DeadBranch
if no such element exist".
"""
assert not self.__finished
node = self.__node_trail[-1]
if node.live_child_count is None:
node.live_child_count = len(values)
node.n = len(values)

assert node.live_child_count > 0 or len(values) == 0

depth = len(self.__choices)

if depth < len(self.__prefix):
i = self.__prefix[depth]
if i >= len(values):
i = 0
else:
i = 0

count = 0
while node.live_child_count > 0:
count += 1
assert count <= len(values)
if not node.children[i].exhausted:
v = values[i]
if condition(v):
self.__choices.append(i)
self.__node_trail.append(node.children[i])
return v
else:
node.children[i] = DeadNode
node.live_child_count -= 1
i = (i + 1) % len(values)
raise DeadBranch()

def finish(self):
"""Record the decisions made in the underlying tree and return
a prefix that can be used for the next Chooser to be used."""
self.__finished = True
assert len(self.__node_trail) == len(self.__choices) + 1

next_value = list(self.__choices)
if next_value:
next_value[-1] += 1
for i in hrange(len(next_value) - 1, -1, -1):
if next_value[i] >= self.__node_trail[i].n:
next_value[i] = 0
if i > 0:
next_value[i - 1] += 1
else:
break

self.__node_trail[-1].live_child_count = 0
while len(self.__node_trail) > 1 and self.__node_trail[-1].exhausted:
self.__node_trail.pop()
assert len(self.__node_trail) == len(self.__choices)
i = self.__choices.pop()
target = self.__node_trail[-1]
target.children[i] = DeadNode
target.live_child_count -= 1

while len(next_value) > 0 and next_value[-1] == 0:
next_value.pop()

return tuple(next_value)


class ChoiceTree(object):
"""Records sequences of choices made during shrinking so that we
can track what parts of a pass has run. Used to create Chooser
objects that are the main interface that a pass uses to make
decisions about what to do.
"""

def __init__(self):
self.root = TreeNode()

@property
def exhausted(self):
return self.root.exhausted

def step(self, prefix, f):
assert not self.exhausted
chooser = Chooser(self, prefix)
try:
f(chooser)
except DeadBranch:
pass
return chooser.finish()


class TreeNode(object):
def __init__(self):
self.children = defaultdict(TreeNode)
self.live_child_count = None
self.n = None

@property
def exhausted(self):
return self.live_child_count == 0


DeadNode = TreeNode()
DeadNode.live_child_count = 0


class DeadBranch(Exception):
pass

0 comments on commit 4ba856e

Please sign in to comment.