Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to opt out of (into?) coverage reporting when collecting observability data #3821

Closed
hgoldstein95 opened this issue Dec 25, 2023 · 3 comments
Labels
interop how to play nicely with other packages performance go faster! use less memory!

Comments

@hgoldstein95
Copy link
Contributor

I'm experiencing significant slowdown (~10x at least) when collecting observability data vs. not. At first I thought the data collection itself was slow, but even a no-op TESTCASE_CALLBACK causes the performance degradation. I was able to narrow the issue down to tracing; if this if-statement is disabled, performance returns to normal.

I think this kind of performance hit is expected for coverage measurement, and that's fine in a lot of cases, but Tyche needs to operate in a pretty tight feedback loop. Can we add a flag that makes coverage measurement optional?

@Zac-HD
Copy link
Member

Zac-HD commented Dec 26, 2023

#3776 means collecting coverage info should be pretty fast on CPython 3.12+, but I'd be happy to add another environment variable and make the _trace_obs calculation a bit more complicated. Want to open a PR?

@Zac-HD Zac-HD added performance go faster! use less memory! interop how to play nicely with other packages labels Dec 26, 2023
@hgoldstein95
Copy link
Contributor Author

Just made one! (Hopefully I did it right). #3826

Zac-HD added a commit that referenced this issue Jan 8, 2024
Address #3821 by adding a flag to turn off coverage reporting for observability
@tybug
Copy link
Member

tybug commented Jan 11, 2024

Looks like this can be closed with the above pr 👍

@tybug tybug closed this as completed Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
interop how to play nicely with other packages performance go faster! use less memory!
Projects
None yet
Development

No branches or pull requests

3 participants