New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove lingering Block allocation #1867

Merged

DRMacIver merged 1 commit into master from DRMacIver/no-blocks-no-masters

Mar 13, 2019

Member

DRMacIver commented Mar 13, 2019

Turns out that as well as lazily allocating Block objects as of #1830 we're also allocating them on the hot path. 🙄 This removes that code.

I think this must have got screwed up in a rebase as I had a bunch of branches in flight at the time.


          Remove lingering Block allocation

21ea425

Zac-HD approved these changes

View reviewed changes

Zac-HD added the performance label

DRMacIver merged commit 45fb108 into master

DRMacIver deleted the DRMacIver/no-blocks-no-masters branch

March 13, 2019 19:33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment