-
Notifications
You must be signed in to change notification settings - Fork 584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "everything but" recipe using from_type #1967
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
@Zac-HD it looks like there may be a flaky test unrelated to this PR. Any thoughts on why this test would start failing? |
Another interesting fail case with Python 2.7 OverflowError: Python int too large to convert to C long I'm tempted to just chop that list of types down to four really boring types... |
🤦♂️ If replacing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great recipes deserve detailed reviews 😄
We've fixed the two unrelated flaky tests too, so rebase on master and next time you push everything should pass.
No description provided.