Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update attrs dependency to >= 19.2 #2111

Merged
merged 1 commit into from Oct 2, 2019
Merged

Update attrs dependency to >= 19.2 #2111

merged 1 commit into from Oct 2, 2019

Conversation

Zac-HD
Copy link
Member

@Zac-HD Zac-HD commented Oct 2, 2019

Use of cmp= is deprecated, and the workaround is a lot clumsier than our one-line getattr for pre-17 attr versions. So given attrs excellent compatibility policy, I thought that the best option was to simply increase the minimum version.

Closes #2110.

@Zac-HD Zac-HD requested a review from DRMacIver as a code owner October 2, 2019 12:52
DRMacIver
DRMacIver approved these changes Oct 2, 2019
View reviewed changes
Copy link
Member

@DRMacIver DRMacIver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have slightly mixed feelings about bumping mandatory requirements even when it's unlikely to break anything, but eh lets YOLO it and see if anyone complains. 😅

@DRMacIver DRMacIver merged commit a48d04f into HypothesisWorks:master Oct 2, 2019
@Zac-HD Zac-HD deleted the bump-attrs branch December 8, 2019 03:30
@tybug tybug mentioned this pull request Dec 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DRMacIver DRMacIver DRMacIver approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

attrs 19.2 cmp warning
2 participants
@Zac-HD @DRMacIver