Actually mark filter iterations as discarded #2757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, you know how we have the
remove_discardedshrink pass specifically designed for e.g. improving the shrinking performance of filtered strategies by removing early iterations in the rejection sampling loop? Neat feature, right?I was writing a short blog post explaining it and then thought I'd double check the code and discovered we weren't actually marking discarded iterations in filtered strategies as discarded, so they were never actually triggering this shrink pass. Whoops. 馃槼
Anyway, this PR fixes that.