Store reference to time.perf_counter for gc accounting #4057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jobh
commented
Jul 22, 2024
| @@ -421,6 +421,10 @@ def find(self, condition: Callable[[T], bool]) -> T: | |||
| _gc_start = 0 | |||
| _gc_cumulative_time = 0 | |||
|
|
|||
| # Since gc_callback potentially runs in test context, and perf_counter | |||
| # might be monkeypatched, we store a reference to the real one. | |||
| _perf_counter = time.perf_counter | |||
There was a problem hiding this comment.
from time import perf_counter would of course be possible, but I think it's wise to make the purpose more obvious by an explicit assignment.
On module level, because we want to patch it in our self-tests.
Zac-HD
approved these changes
Jul 22, 2024
Comment on lines
+3
to
+4
| This patch addresses the issue of hypothesis potentially accessing | ||
| mocked ``time.perf_counter`` during test execution (:issue:`4051`). |
There was a problem hiding this comment.
I think this is technically too general a claim, because we also use perf_counter() when drawing from a strategy and that can happen inline - e.g. via st.functions() or st.data(). But being super-precise here that it addresses some cases doesn't seem like a big deal.
There was a problem hiding this comment.
A case for centralizing and replacing import time with from hypothesis.internal import time perhaps? Later, anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4051.