-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix more CS issues #5
Conversation
->files() | ||
->name('.php_cs') | ||
->name('*.php') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PCRE vs. glob, why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because glob works pretty well. With the PCRE, it seemed like some files were not matcher (those under the php
folder)
@@ -2,8 +2,7 @@ | |||
|
|||
namespace mageekguy\atoum\asserter; | |||
|
|||
use mageekguy\atoum | |||
; | |||
use mageekguy\atoum; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you fix them by hand or with PHP CS Fixer? Why the .php_cs
conf did not fix them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
by hand
->files() | ||
->name('.php_cs') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe:
- '.php_cs'
+ __FILE__
Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
No description provided.