Remove interpreter needing to be relative to "share" directory #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vici37
commented
Feb 27, 2024
| # with the only update being to support reading files from FileStorage | ||
| private def require_file(node : Require, filename : String) | ||
| parser = @program.new_parser( | ||
| File.exists?(filename) ? File.read(filename) : FileStorage.get(filename).gets_to_end |
There was a problem hiding this comment.
Only this line was changed in the copy/paste of the method.
|
Hm, I still think this is a cool idea, but I keep finding more places in the compiler / interpreter that assumes direct file access that breaks because of this change. I'm gonna close this for now and keep at it on my own machine. Give a shout if you're interested in this idea, at least :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the baked_file_system shard to add the entire
sharedirectory to the built binary, and then adds various monkey patches to allow thepreludeto read those files from the virtual filesystem if they don't exist in their expected location.This allows the constructed
icbinary to not need alibspecific setup / build, and can potentially be run on machines without crystal installed at all (but still require the linked dynamic libraries).Let me know if you find this useful, or don't wish to make such edits or updates to the interpreter directly :)