Add industry variables #90
Conversation
There was a problem hiding this comment.
Thanks @macflo8 for this well-structured PR. I made quite a few comments, so it might make sense to split this PR into several components for easier review and discussion...
| @@ -0,0 +1,16 @@ | |||
| # material demand by commodity and demand sector | |||
| - Demand|Iron and Steel|Steel|{Demand Sector}: | |||
There was a problem hiding this comment.
Is there a reason why this is not {Iron Commodity}?
| description: x {Pulp and Paper Commodity} scrap from {Demand Sector} | ||
| unit: Mt/yr | ||
|
|
||
| - Total Scrap|Iron and Steel|Steel|{Demand Sector}: |
There was a problem hiding this comment.
The difference between collected and total scrap is not clear to me - what is uncollected scrap?
There was a problem hiding this comment.
The idea behind "collected scrap" was that it is collected to be recycled. In this case, uncollected scrap is not collected in the recycling system and would be dumped. The word "recycled" can be easier to understand.
| - Non-Ferrous Metals Commodity: | ||
| - Aluminum: | ||
| description: Aluminum, commonly produced by electrolysis of alumina or re-melting of scrap | ||
| - Secondary Aluminum: |
There was a problem hiding this comment.
Should "Secondary Aluminum" a subcategory of Aluminum?
| @@ -0,0 +1,19 @@ | |||
| - Production|{Industry Sector} [{Production Unit}]: # ???: do we need this aggregate? | |||
There was a problem hiding this comment.
Probably not needed, so let's leave this out until we find a relevant use case
|
|
||
| - Production|Iron and Steel|{Iron Commodity} [{Production Unit}]: | ||
| description: Production of {Iron Commodity} in {Production Unit} | ||
| unit: Mt/yr |
There was a problem hiding this comment.
You use the tag-list for "Production Unit", but the "Value"-variable should not have the unit Mt/yr but USD_2010/yr. So either you also set the units depending on the tag-list or you only create the Volumne-variable-variant in this PR.
|
Thanks @danielhuppmann for the suggestions! Most of the variable names were copied from the NAVIGATE template, but I agree that some variable names should be improved/changed. |
|
You can either rephrase the description or put the entire string in quotes to avoid the error when starting with a About the renaming, yes, we should use previous projects as starting point but improve and harmonize where possible. You can add the variable-name from the previous project as an attribute so that we can implement automated translation/migration later, see the example below... |
| @@ -0,0 +1,32 @@ | |||
|
|
|||
| - Collected Scrap|Iron and Steel|Steel|{Demand Sector}: | |||
| description: Steel scrap from {Demand Sector} | |||
There was a problem hiding this comment.
In the description, we can clarify that "collected scrap" is the amount that is collected to be recycled.
| - Collected Scrap|Iron and Steel|Steel|{Demand Sector}: | ||
| description: Steel scrap from {Demand Sector} | ||
| unit: Mt/yr | ||
| - Collected Scrap|Non-Metallic Minerals|{Non-Metallic Minerals Commodity}|{Demand Sector}: |
There was a problem hiding this comment.
Actually, scrap is a terminology used for metals but not so much for other materials. We can either use it just for metals or to be consistent across all materials, we could adopt the terminology "waste" which can cover metals, non-metallic minerals, plastics, and others. In this case "Collected Waste" might sound confusing. To be more comprehensive we can have something like e.g. "Waste|Non-Metalic Minerals", "Waste|Recycling|Non-Metalic Minerals", (and later if needed other waste treatment methods "Waste|Landfilling|Non-Metallic Minerals", "Waste|Other|Non-Metallic Minerals", "Waste|Downcycling|Non-Metallic Minerals")
There was a problem hiding this comment.
Separating these variables into Scrap vs Waste and call it Total (with an extended description, please) vs. Recycled makes a lot of sense to me, thanks!
| @@ -0,0 +1,13 @@ | |||
| - Non-Ferrous Metals Commodity: | |||
| - Aluminum: | |||
There was a problem hiding this comment.
As another subcategory of aluminum, we could add bauxite here similar to including iron ore.
| unit: Mt/yr | ||
|
|
||
| - Export|Industry|Iron and Steel|{Iron Commodity}|{Production Unit}: | ||
| description: Production of {Iron Commodity} |
There was a problem hiding this comment.
In the description, not production but export
|
|
||
|
|
||
| - Import|Industry|{Industry Sector}|{Production Unit}: # ???: do we need this aggregate? | ||
| description: Total production of commodities by sector |
There was a problem hiding this comment.
In the description, not production but import
1) remove unused files 2) update variable descriptions and add tags 3) fix paper commodity names 4) comment out unused material stock variables for now
Resolve error with {Tag} at beginning of line
Rename "Production Unit" tag to "Accounting Type" Add tag-specific units
Rename all mentions of "demand" to "consumption" As "Production" is used for materials instead of "Supply", "Demand" should be called renamed to "Consumption"
Move "Accounting Type" tag from subcategory to bracket As agreed in IAMconsortium#55 methods/units should not be a subcategory but put into brackets of a variable category
Add missing NAVIGATE variables and add "navigate" value where applicable
There was a problem hiding this comment.
Thanks @macflo8 for continuing this PR, see a few inline comments...
| @@ -0,0 +1,16 @@ | |||
| # material demand by commodity and demand sector | |||
| - Consumption|Iron and Steel|Steel|{Consumption Sector}: | |||
| description: consumption of steel commodities in {Consumption Sector} | |||
There was a problem hiding this comment.
Sorry, I think my previous comment led to a misunderstanding - please capitalize in the description a variable but start with lower-case in the description of tag-lists
|
|
||
| - Collected Scrap|Iron and Steel|Steel|{Consumption Sector}: |
There was a problem hiding this comment.
| - Collected Scrap|Iron and Steel|Steel|{Consumption Sector}: | |
| - Collected Scrap|Iron and Steel|Steel|{Consumption Sector}: |
| description: simplest alcohol used as precursor for various chemicals and fuels | ||
| - Formaldehyde: | ||
| description: simplest aldehyde, mainly used to produce resins | ||
| - Formaldehyde resins: |
There was a problem hiding this comment.
| - Formaldehyde resins: | |
| - Formaldehyde Resins: |
| description: most produced fertiliser type | ||
| - Methanol: | ||
| description: simplest alcohol used as precursor for various chemicals and fuels | ||
| - Formaldehyde: |
There was a problem hiding this comment.
What's the difference between this type and resins? Can something be added to clearly distinguish this from the resins?
| # Industry sectors as used in IEA World Energy Balances (2022 Edition) | ||
| - Industry Sector: | ||
| - Mining: | ||
| description: industry sectors categorized as ISIC Rev. 4 Divisions 07 and 08 and Group 099 |
There was a problem hiding this comment.
Suggest to still repeat the actual sector name in the description
| description: industry sectors categorized as ISIC Rev. 4 Divisions 07 and 08 and Group 099 | |
| description: industry sectors categorized as ISIC Rev. 4 Divisions 07 and 08 and Group 099 |
| description: industry sectors categorized as ISIC Rev. 4 Divisions 41-43 | ||
| - Iron and Steel: | ||
| description: industry sectors categorized as ISIC Rev. 4 Group 241 and Class 2431 | ||
| - Non-ferrous Metals: |
There was a problem hiding this comment.
| - Non-ferrous Metals: | |
| - Non-Ferrous Metals: |
| description: industry sectors categorized as ISIC Rev. 4 Group 241 and Class 2431 | ||
| - Non-ferrous Metals: | ||
| description: industry sectors categorized as ISIC Rev. 4 Group 242 and Class 2432, basic industries | ||
| - Non-metallic Minerals: |
There was a problem hiding this comment.
| - Non-metallic Minerals: | |
| - Non-Metallic Minerals: |
| description: industry sectors categorized as ISIC Rev. 4 Divisions 20 and 21 | ||
| - Machinery: | ||
| description: industry sectors categorized as ISIC Rev. 4 Divisions 25-28 | ||
| - Transport equipment: |
There was a problem hiding this comment.
| - Transport equipment: | |
| - Transport Equipment: |
| description: industry sectors categorized as ISIC Rev. 4 Divisions 10-12 | ||
| - Paper and Pulp: | ||
| description: industry sectors categorized as ISIC Rev. 4 Divisions 17 and 18 | ||
| - Textile and leather: |
There was a problem hiding this comment.
| - Textile and leather: | |
| - Textile and Leather: |
| @@ -0,0 +1,15 @@ | |||
| - Production|Iron and Steel|{Iron Commodity} [{Accounting Type}]: | |||
| description: production of {Iron Commodity} in {Accounting Type} | |||
There was a problem hiding this comment.
Please add "given as {Accounting Type}" to all variables where the Accounting-Type is used
| description: production of {Iron Commodity} in {Accounting Type} | |
| description: production of {Iron Commodity} given as {Accounting Type} |
This PR is a first draft to add industry and bulk/specialty materials related variables to the data template.
The following variable "categories" are added: