2.01 update tests #120
Merged
2.01 update tests #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a simple commit to just make the files pass. Further work is needed to make sure they actually reflect the tests they have been designed to cover
reasons Two new tests added, but these should not be seen as comprehensive. All tests should be reviewed, and new tests added to check all aspects of the activity schema
This was referenced Jun 26, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the should-pass and should-fail tests updated for version 2.01
There is still work to do, but this is a first fix to make sure everything that exists now passes or fail as expected. Further work is need to check that the tests are comprehensive.