Add iati-activity/result/reference and test cases #383
Conversation
| <title> | ||
| <narrative>Sample text</narrative> | ||
| </title> | ||
| <reference/><!-- FAIL: Optional `reference` element present, but both the mandatory `code` and `vocabulary` attributes are not present. --> |
There was a problem hiding this comment.
If they are tested individually, this test file is not required.
(and if they aren't tested individually, this test file doesn't check the things that each is required)
...and there's no manner in XSD 1.0 to say that one of a pair of attributes is required https://stackoverflow.com/a/763108
There was a problem hiding this comment.
Fixed in 1729f95.
| <narrative>Sample text</narrative> | ||
| </title> | ||
| <reference vocabulary="xx" code="xx"><!-- PASS: Optional `reference` element present, with two mandatory attributes. --> | ||
| <example-namespace:namespace-element></example-namespace:namespace-element><!-- Optional namespace element included. --> |
There was a problem hiding this comment.
Could be clearer that this is what is being tested.
There was a problem hiding this comment.
I've made changes in 59a684c - is it clearer now?
| @@ -0,0 +1,33 @@ | |||
| <?xml version="1.0"?> | |||
There was a problem hiding this comment.
Is this needed? Isn't it covered by the minimal IATI file case?
There was a problem hiding this comment.
Nvm, leave for integration branch as needs to be moved to result level folder.
There was a problem hiding this comment.
Fixed in e23a674 anyway!
Each required attribute is tested indivually, so there is no need to test that both are not present. Additionally there is no manner in XSD 1.0 to say that one of a pair of attributes is required.
Fixes #362