Improve coordinate checks #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is permitted against the Standard, though use of this coordinate in actual data is almost certainly incorrect - it's in the ocean
|
Tests failed :-( |
dalepotter
reviewed
May 15, 2017
| @@ -243,13 +243,18 @@ def valid_value(value_element): | |||
|
|
|||
|
|
|||
| def valid_coords(x): | |||
There was a problem hiding this comment.
Could we make life easier for ourselves in future by documenting this function to our better practices...
Suggest adding a docstring here
dalepotter
reviewed
May 15, 2017
stats/dashboard.py
Outdated
| if x == 0 and y ==0: | ||
| if x == 0 and y == 0: | ||
| return False | ||
| elif x < -90 or x > 90 or y < -180 or y > 180: |
There was a problem hiding this comment.
Also, on the documentation front: might be worth adding a one-line comment to say what this is doing...
dalepotter
suggested changes
May 15, 2017
|
Documentation added. Also changed coordinate naming to clarify that we're talking |
dalepotter
approved these changes
Jun 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes several improvements to better check whether a coordinate is valid.
(0,0)coordinate is not a correct coordinate, despite being valid against the IATI Standard (it's in the ocean and so almost certainly an incorrect value)Tests have been added.