Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: falsey tests for var which can be None #342

Merged
merged 1 commit into from
Aug 1, 2024
Merged

fix: falsey tests for var which can be None #342

merged 1 commit into from
Aug 1, 2024

Conversation

simon-20
Copy link
Collaborator

@simon-20 simon-20 commented Aug 1, 2024

  • Tests for falsity of file_schema_valid was changed in response to flake8 warnings about use of '==' , but recommended action was not semantically equivalent--this commit restores original behaviour and passes flake8 checks.

@simon-20
fix: falsey tests for var which can be None
97f68d8 
* Tests for falsity of file_schema_valid was changed in response to flake8 warnings about use of '==' , but recommended action was not semantically equivalent--this commit restores original behaviour and passes flake8 checks.
@simon-20 simon-20 merged commit fe72f57 into develop Aug 1, 2024
2 checks passed
@simon-20 simon-20 deleted the fix_falsey_tests branch August 1, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bjwebb Bjwebb Bjwebb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simon-20 @Bjwebb