Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix exception when routing to company #87

Closed
wants to merge 2 commits into from
Closed

Fix exception when routing to company #87

wants to merge 2 commits into from

Conversation

achohbee
Copy link

@achohbee achohbee commented May 2, 2024

Fix exception that gets thrown when trying to route to the company.

@achohbee
Fix exception when routing to company
404b388 
Fix exception that gets thrown when trying to route to the company.
@achohbee
Copy link
Author

achohbee commented May 2, 2024

This is a quick and fast kludge, there might be a better fix for an underlying problem. Also untested at the moment, I can muck around getting this to build local for me later to test.

The callstack that gets sent to terminal whenever you try to hit enter after typing in company is:

LethalLevelLoader.TerminalManager.LockedNodeEventTest (TerminalNode& currentNode, TerminalNode& loadNode) (at <bed140a3e66641339c3af806fdbbd3ed>:IL_0006)
LethalLevelLoader.TerminalManager.OnBeforeLoadNewNode (TerminalNode& node) (at <bed140a3e66641339c3af806fdbbd3ed>:IL_004D)
LethalLevelLoader.Patches.TerminalLoadNewNode_Prefix (Terminal __instance, TerminalNode& node) (at <bed140a3e66641339c3af806fdbbd3ed>:IL_001B)
(wrapper dynamic-method) Terminal.DMD<Terminal::LoadNewNode>(Terminal,TerminalNode)
(wrapper dynamic-method) Terminal.DMD<Terminal::OnSubmit>(Terminal)
UnityEngine.Events.InvokableCall.Invoke () (at <e27997765c1848b09d8073e5d642717a>:IL_0010)
UnityEngine.Events.UnityEvent`1[T0].Invoke (T0 arg0) (at <e27997765c1848b09d8073e5d642717a>:IL_0049)
TMPro.TMP_InputField.SendOnEndEdit () (at <9baa8119dbcd498f902c1a92f10843c1>:IL_000E)
TMPro.TMP_InputField.ReleaseSelection () (at <9baa8119dbcd498f902c1a92f10843c1>:IL_001B)
TMPro.TMP_InputField.DeactivateInputField (System.Boolean clearSelection) (at <9baa8119dbcd498f902c1a92f10843c1>:IL_00B0)
TMPro.TMP_InputField.OnUpdateSelected (UnityEngine.EventSystems.BaseEventData eventData) (at <9baa8119dbcd498f902c1a92f10843c1>:IL_007C)
UnityEngine.EventSystems.ExecuteEvents.Execute (UnityEngine.EventSystems.IUpdateSelectedHandler handler, UnityEngine.EventSystems.BaseEventData eventData) (at <17de86d66286445fa95af59fa8fa644d>:IL_0000)
UnityEngine.EventSystems.ExecuteEvents.Execute[T] (UnityEngine.GameObject target, UnityEngine.EventSystems.BaseEventData eventData, UnityEngine.EventSystems.ExecuteEvents+EventFunction`1[T1] functor) (at <17de86d66286445fa95af59fa8fa644d>:IL_0067)
UnityEngine.EventSystems.EventSystem:Update()

@achohbee @IHaveNoNameYetIDo
Update LethalLevelLoader/Patches/TerminalManager.cs
53d5807 
Co-authored-by: IHaveNoNameYetIDo <ihavenonameyetido@outlook.com>
WhiteSpike added a commit to WhiteSpike/LethalLevelLoader that referenced this pull request May 11, 2024
@WhiteSpike
Fixed "Not being able to route to The Company Moon" issue IAmBatby#91, …
5950bb7 
…IAmBatby#87, IAmBatby#83 , IAmBatby#80 , IAmBatby#78, IAmBatby#77

- ``ExtendedLevel.cs``
  - Removed the restriction of applying the terminal node changes on custom levels only.
  - Reasoning being that it's easier for every level to follow a standard rather than having special cases (CompanyRoute having a displayPlanetInfo of -1, leading to OutOfBounds).

- ``General/Patches.cs``
  - Changed applying the ``SetLevelID()`` method from ``CustomExtendedLevels`` to ``ExtendedLevels`` to include the vanilla moons as well.

- ``AssetBundleLoader.cs``
  - Added case to acquire the terminal nodes associated to the Company Moon due to the noun object name being ``CompanyMoon`` rather than ``Gordion``.
@IAmBatby
Copy link
Owner

Closing, Fixed in v1.2.0.3

@IAmBatby IAmBatby closed this May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IHaveNoNameYetIDo IHaveNoNameYetIDo IHaveNoNameYetIDo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@achohbee @IAmBatby @IHaveNoNameYetIDo