Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New mask types and change proposal #482

Closed
7 tasks done
phimage opened this issue May 14, 2017 · 4 comments
Closed
7 tasks done

New mask types and change proposal #482

phimage opened this issue May 14, 2017 · 4 comments

Comments

@phimage
Copy link
Member

phimage commented May 14, 2017

Change proposal for faster new mask type implementation

  • MaskType enum could provide an UIBezierPath using a function like this func bezierPath(for rect: CGRect)
  • Then in MaskDesignable we ask the path and call the draw function only one time code

I think also a lot of code to create UIBezierPath must done in one UIBezierPath extension instead of MaskDesignable or MaskType
For instance

extension UIBezierPath {
    public convenience init(triangleInRect rect: CGRect) {
        // code from getTriangleBezierPath
    }
}

New mask type

I have already a lot of UIBezierPath code to create the following path

You can copy paste the list and checked the one you think that could be useful as mask layer

@JakeLin
Copy link
Member

JakeLin commented May 15, 2017

@phimage Great, will make an educational game with my son using IBAniamtable soon ❤️❤️❤️

@phimage
Copy link
Member Author

phimage commented Oct 18, 2017

Change proposal approved here #517
Implementation of some mask here #518

@phimage
Copy link
Member Author

phimage commented Oct 20, 2017

plus and drop #519

@phimage
Copy link
Member Author

phimage commented Oct 21, 2017

mask

phimage added a commit that referenced this issue Oct 24, 2017
Add new mask types .drop, .plusSign and .moon Close #482
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants