Add ellipse mask type #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
JakeLin
approved these changes
May 15, 2017
tbaranes
approved these changes
May 15, 2017
|
Travis is failing because Danger has reported "CHANGELOG missing", once the entry added, travis should be green! |
|
I know, no PR could be done in one commit, even the little one 😭 And when I will merge this one with CHANGELOG update, I have some probability of having conflict with #478 💀 |
|
If you really want only one commit, you can amend the changelog update in your branch, then force push. It will make this PR ready to go with one commit only! |
|
@phimage well done 🎉🎉🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing
trianglein demoFirst attempt on
MaskTypeI have others mask to propose, I will make an issue
#482