-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introducing "IB" #no-public-changes #529
Conversation
@tbaranes 💪 thanks for picking up this feature quickly, it is a fun and challenging one. It is a great start 👍
I think we need to do more than just
Is it possible to provide a
I prefer adding code comments as documentation now. We may add documentation comment in |
Which component do you have in mind? Anyway, I think we can start by supporting only
Sounds good to me, I don't really have a preference. Should we create a dedicated PR for this once the feature itself is more advanced? |
|
Travis failing due to the tests, will pass once #530 has been merged and rebased |
Generated by 🚫 Danger |
@JakeLin Ready for final review considering that docs will be added in another PR! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 It's good to go
@tbaranes great work 👍 |
I take a look at #528 to make
IBAnimatable
working without interface builder, AND without subviews.This PR implements a working solution for this issue, currently supporting:
Usage:
In order to get this, I had to change each protocols to add a
configure(in view: UIView)
sinceib
is not a view itself. It will ask a bit of work to refactor all of them, but it will work in the end. There's one issue left: how to "reload" the properties when rotating, bounds did change... all the work currently inlayoutSubviews
Other branches related to this feature ready to go (after a rebase):
feature/ib_borderdesignable
Also, I don't know how we should document (documentation + demo project) this, any suggestions?