Fix view's borders when using it with corner radius allSides
#530
Conversation
tbaranes
force-pushed
the
hotfix/allsides_border_corner
branch
from
d59cc7c
to
e2f57e9
Compare
tbaranes
force-pushed
the
hotfix/allsides_border_corner
branch
from
e2f57e9
to
4923ea4
Compare
|
|
||
| // if a layer mask is specified, remove it | ||
| layer.mask?.removeFromSuperlayer() | ||
| layer.mask = cornerSidesLayer() |
There was a problem hiding this comment.
can we encapsulate the code since they are very similar?
There was a problem hiding this comment.
If that's ok with you, I will do the refactor in #529 since I'm already refactoring a bit the class there
|
Travis was failing because of the tests, I fixed most of them, but there's still one failing that I don't understand why. I welcome any idea 🤔 |
|
@tbaranes I'm sorry I missed this. If there's a problem with something I wrote, please tag me in the future |
|
You didn’t really miss it, my comment has been posted less than 2h ago! The tests are failing due to my change, your code is really clear and understandable but path are a bit tricky sometimes 😀 |
|
It's still going after 6 hours @_@ I hate travis |
|
@SD10 Yeah, travis is completely down these days, but it will fail since the test is failing locally. |
tbaranes
force-pushed
the
hotfix/allsides_border_corner
branch
from
9050206
to
d932fc9
Compare
|
Finally understood why that last test didn't pass, travis should be green now! |
Generated by 🚫 Danger |
|
@tbaranes I'm not sure if you know, I just learned this a couple months ago to remove those annoying SwiftLint warnings:
|
The border doesn't respect the
allSidesradius when both are set. Using a custom layer for every radius fix this.