This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

Support adding image descriptions #10

Closed

IBBoard opened this issue Sep 1, 2019 · 1 comment

Labels

accessibility design enhancement

Owner

IBBoard commented Sep 1, 2019 •

edited

Loading

For accessibility, we should support adding image descriptions.

The API is documented at https://developer.twitter.com/en/docs/media/upload-media/api-reference/post-media-metadata-create

(Reported by @lucaswerkmeister as baedert/corebird#678)

IBBoard added the enhancement label

IBBoard mentioned this issue

Support showing/reading image descriptions #11

Closed

IBBoard added the design label

valerierx mentioned this issue

Cawbird 1.0.3 (current git tip) coredumps on startup #51

Closed

schmittlauch mentioned this issue

Cawbird crashes & dumps core at launch #70

Closed

IBBoard added the accessibility label

IBBoard mentioned this issue

Cawbird accessibility #143

Closed

IBBoard added a commit that referenced this issue


          Re #10: Add char counter without shortened links

f80134e

Tweets use t.co URLs and so all links count as their shortened length.
Descriptions don't shorten URLs, but do use the Twitter weighting rules.
We now have a short-circuit that does the counting without tokenising
so that it just counts raw characters.

IBBoard added a commit that referenced this issue


          Re #10: Add a "describe image" UI when composing

2e6596b

This is currently a modal dialog. It appears to work *except* that when
posting the tweet then the Twitter API doesn't return the descriptions
to you, so your own tweets won't show the descriptions
until you close and reload all tweets (or view through Profile view etc)

Owner Author

IBBoard commented Aug 9, 2020

To do:

Save and load image descriptions when saving tweet
Save and load image descriptions for favourite images
Fix Twitter's oversight where the description doesn't come back in the posted tweet's JSON

IBBoard added a commit that referenced this issue


          Re #10: Add image description window title to i18n

8371fa0

IBBoard added a commit that referenced this issue


          Re #10: Consistency cleanup

27da983

IBBoard added a commit that referenced this issue


          Re #10: Add accessible names/descriptions

fc98744

IBBoard added a commit that referenced this issue


          Re #10: Add image to description window

451b325

It helps to be able to see what you're describing!

Also improved accessibility of the text length counter

IBBoard added a commit that referenced this issue


          Re #10: Use a new resizable image widget

Before we could increase but never shrink.

Now we can resize, but sometimes the text input disappears
off the bottom of the window for some reason.

IBBoard added a commit that referenced this issue


          Re #10: Remove unused event window

79b56a7

Code copies from MediaButton but we don't do the prelight
so we don't need all the baggage that comes with it.

IBBoard added a commit that referenced this issue


          Re #10: Fix image causing overflow of window

6c6a4e2

Minimum should be actual minimum, not "the smallest we'd like
at the moment".

Increased minimum to 120px because 40px images are tiny and this
is meant for previewing images when describing them.

IBBoard added a commit that referenced this issue


          Re #10: Load images later to fix stacking

c53b939

If we load images in the constructor then button hit-zones go under
the image but new images have the buttons fully accessible.
But the buttons are still visible, so it's not a complete z-index mixup.

By hooking in to "show()" we can load images late enough that
GTK behaves differently and stacks the button hit-zones correctly.

IBBoard added a commit that referenced this issue


          Re #10: Realign widgets

81b5f5e

Now that we have top and bottom buttons, the alignment is better
if images, completion check marks and progress bars are centralised

IBBoard added a commit that referenced this issue


          Re #10: Add note about own annotations

bd3ac52

There's no point hacking them in now if the new API does the right thing

IBBoard closed this as completed

IBBoard added a commit that referenced this issue


          Re #10: Add char counter without shortened links

4fca81f

Tweets use t.co URLs and so all links count as their shortened length.
Descriptions don't shorten URLs, but do use the Twitter weighting rules.
We now have a short-circuit that does the counting without tokenising
so that it just counts raw characters.

IBBoard added a commit that referenced this issue


          Re #10: Add a "describe image" UI when composing

a759070

This is currently a modal dialog. It appears to work *except* that when
posting the tweet then the Twitter API doesn't return the descriptions
to you, so your own tweets won't show the descriptions
until you close and reload all tweets (or view through Profile view etc)

IBBoard added a commit that referenced this issue


          Re #10: Add image description window title to i18n

eb04584

IBBoard added a commit that referenced this issue


          Re #10: Consistency cleanup

431a38b

IBBoard added a commit that referenced this issue


          Re #10: Add accessible names/descriptions

3d1f726

IBBoard added a commit that referenced this issue


          Re #10: Add image to description window

b88bd23

It helps to be able to see what you're describing!

Also improved accessibility of the text length counter

IBBoard added a commit that referenced this issue


          Re #10: Use a new resizable image widget

1906ba4

Before we could increase but never shrink.

Now we can resize, but sometimes the text input disappears
off the bottom of the window for some reason.

IBBoard added a commit that referenced this issue


          Re #10: Remove unused event window

cef5901

Code copies from MediaButton but we don't do the prelight
so we don't need all the baggage that comes with it.

IBBoard added a commit that referenced this issue


          Re #10: Fix image causing overflow of window

6f775da

Minimum should be actual minimum, not "the smallest we'd like
at the moment".

Increased minimum to 120px because 40px images are tiny and this
is meant for previewing images when describing them.

IBBoard added a commit that referenced this issue


          Re #10: Load images later to fix stacking

3c9abde

If we load images in the constructor then button hit-zones go under
the image but new images have the buttons fully accessible.
But the buttons are still visible, so it's not a complete z-index mixup.

By hooking in to "show()" we can load images late enough that
GTK behaves differently and stacks the button hit-zones correctly.

IBBoard added a commit that referenced this issue


          Re #10: Realign widgets

503b5ad

Now that we have top and bottom buttons, the alignment is better
if images, completion check marks and progress bars are centralised

IBBoard added a commit that referenced this issue


          Re #10: Add note about own annotations

4f1bab0

There's no point hacking them in now if the new API does the right thing

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.