Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

Support showing/reading image descriptions #11

Closed
IBBoard opened this issue Sep 1, 2019 · 2 comments
Closed

Support showing/reading image descriptions #11

IBBoard opened this issue Sep 1, 2019 · 2 comments
Labels
accessibility design UI and design issues enhancement New feature or request

Comments

@IBBoard
Copy link
Owner

IBBoard commented Sep 1, 2019

Related to #10 - since Twitter provides image descriptions (somewhere in the JSON) we should add them to the images when we display them.

Unless anyone has any better options, I'd plan to put them in as a tooltip.
@IBBoard IBBoard added enhancement New feature or request design UI and design issues labels Sep 1, 2019
@valerierx valerierx mentioned this issue Oct 21, 2019
Closed
@schmittlauch schmittlauch mentioned this issue Jan 5, 2020
Closed
@IBBoard
Copy link
Owner Author

IBBoard commented Apr 7, 2020

Alt text is accessible to any Twitter app and is requested using the include_ext_alt_text parameter.

The alt text will appear as a top-level key of each media object in the extended_entities object. For example:

"extended_entities": { "media": [ { "id_str": "696049944105320448", ... "ext_alt_text": "A Faema Urania lever espresso machine" } ] }

https://blog.twitter.com/developer/en_us/a/2016/alt-text-support-for-twitter-cards-and-the-rest-api.html

@IBBoard IBBoard mentioned this issue Jul 21, 2020
Closed
IBBoard added a commit that referenced this issue Aug 8, 2020
@IBBoard
Re #11: Extract alt text from JSON
4520342 
Also stripped back media parsing because images
were taking the non-extended media, which didn't include the
alt-text, and the docs say to just use the extended objects.
IBBoard added a commit that referenced this issue Aug 8, 2020
@IBBoard
Re #11: Add alt text as a tooltip to images
f5aad15 
If there is no alt text (it's null) then no tooltip will show
IBBoard added a commit that referenced this issue Aug 8, 2020
@IBBoard
Re #11: Make sure we load alt text on all feeds
52769cd
IBBoard added a commit that referenced this issue Aug 8, 2020
@IBBoard
Re #11: Parse an alternate alt-text source
00de386 
Content from advertisers (and brands) might be embedded differently.
On Twitter it has a title in bold underneath and a description. That is
included in the JSON, so fall back to that if there's no alt text.
IBBoard added a commit that referenced this issue Aug 8, 2020
@IBBoard
Re #11: Fix null JSON object warnings
a5d3f6a 
Some media has "additional_media_information" without a
title and description.
IBBoard added a commit that referenced this issue Aug 8, 2020
@IBBoard
Re #11: Mark annotated images with "info" icon
a9b96ae 
I'd rather have "letter i in circle" info, but we'll use whatever is in
the user's current theme so that we fit in.
@IBBoard
Copy link
Owner Author

IBBoard commented Aug 8, 2020

That'll do for an initial version. It even deals with long, multi-line descriptions! (e.g. https://twitter.com/IBBTwtr/status/1292118481333358592)

The icon we use is themed and hopefully provides an indicator for there being a description while not getting in the way.

Any issues with it can go in new tickets.

@IBBoard IBBoard closed this as completed Aug 8, 2020
IBBoard added a commit that referenced this issue Aug 9, 2020
@IBBoard
Re #11: Set accessible descriptions
3d7a775 
Tooltips may not be enough (depending on screenreader settings)
so use the a11y API to set a description as well.
IBBoard added a commit that referenced this issue Aug 14, 2020
@IBBoard
Re #11: Fix media description for empty title/desc
dbf4731
IBBoard added a commit that referenced this issue Aug 22, 2020
@IBBoard
Re #11: Extract alt text from JSON
6522c91 
Also stripped back media parsing because images
were taking the non-extended media, which didn't include the
alt-text, and the docs say to just use the extended objects.
IBBoard added a commit that referenced this issue Aug 22, 2020
@IBBoard
Re #11: Add alt text as a tooltip to images
003a4fc 
If there is no alt text (it's null) then no tooltip will show
IBBoard added a commit that referenced this issue Aug 22, 2020
@IBBoard
Re #11: Make sure we load alt text on all feeds
d3569b4
IBBoard added a commit that referenced this issue Aug 22, 2020
@IBBoard
Re #11: Parse an alternate alt-text source
d171e7c 
Content from advertisers (and brands) might be embedded differently.
On Twitter it has a title in bold underneath and a description. That is
included in the JSON, so fall back to that if there's no alt text.
IBBoard added a commit that referenced this issue Aug 22, 2020
@IBBoard
Re #11: Fix null JSON object warnings
7759a43 
Some media has "additional_media_information" without a
title and description.
IBBoard added a commit that referenced this issue Aug 22, 2020
@IBBoard
Re #11: Mark annotated images with "info" icon
923cf71 
I'd rather have "letter i in circle" info, but we'll use whatever is in
the user's current theme so that we fit in.
IBBoard added a commit that referenced this issue Aug 22, 2020
@IBBoard
Re #11: Set accessible descriptions
4066822 
Tooltips may not be enough (depending on screenreader settings)
so use the a11y API to set a description as well.
IBBoard added a commit that referenced this issue Aug 22, 2020
@IBBoard
Re #11: Fix media description for empty title/desc
faaedff
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accessibility design UI and design issues enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@IBBoard