Skip to content
This repository has been archived by the owner on Jan 31, 2023. It is now read-only.

Stop/Restart the non-started Local Fabric #1500

Closed
2 tasks
Jakeeyturner opened this issue Oct 7, 2019 · 2 comments
Closed
2 tasks

Stop/Restart the non-started Local Fabric #1500

Jakeeyturner opened this issue Oct 7, 2019 · 2 comments
Assignees
@Jakeeyturner
Labels
bug Something isn't working sev3
Milestone
Sprint 28

Comments

@Jakeeyturner
Copy link
Contributor

Description

As a user, I probably shouldn't see the option to stop/restart the non-started Local Fabric.

Expected Behavior

On the tree item, I shouldn't see the option to stop/restart the non-started Local Fabric environment.
From the command palette, it should just error out and warn the user the Local Fabric hasn't been started. We could even use the package.json contribution points to hide the command, unless the Local Fabric is running.

Actual Behavior

I am able to attempt to stop the non-started Local Fabric.

Possible Fix

Remove the tree item option if the Local Fabric hasn't been started & throw a better error if the user attempts to stop (or even restart).

Alternatively, hide the command from the palette unless the Local Fabric has been started.

Steps to Reproduce

Existing issues

Log File

Your Environment

  • IBM Blockchain Platform Extension Version:
  • Visual Studio Code version:
  • Environment name and version (e.g. Node.js v8.12.0, npm v6.4.1):
  • Operating System and version:
  • Link to your project:
@Jakeeyturner Jakeeyturner added the bug Something isn't working label Oct 7, 2019
@cazfletch
Copy link
Contributor

We should probably hide the command rather than error

@cazfletch cazfletch added the sev3 label Oct 8, 2019
@cazfletch cazfletch modified the milestones: Sprint 17, Sprint 18 Oct 8, 2019
@cazfletch cazfletch assigned cazfletch and unassigned cazfletch Oct 22, 2019
@cazfletch cazfletch modified the milestones: Sprint 18, Sprint 19 Oct 23, 2019
@cazfletch cazfletch removed this from the Sprint 19 milestone Dec 10, 2019
@cazfletch cazfletch added this to the Sprint 27 milestone Mar 5, 2020
@Jakeeyturner Jakeeyturner self-assigned this Mar 17, 2020
Jakeeyturner added a commit to Jakeeyturner/blockchain-vscode-extension that referenced this issue Mar 17, 2020
@Jakeeyturner
Disable stop/restart on stopped local runtime from tree (close IBM-Bl…
7ef562b 
…ockchain#1500)

Signed-off-by: Jake Turner <jaketurner25@live.com>
Jakeeyturner added a commit to Jakeeyturner/blockchain-vscode-extension that referenced this issue Mar 17, 2020
@Jakeeyturner
Disable stop/restart on stopped local runtime from tree (close IBM-Bl…
7989ae8 
…ockchain#1500)

Signed-off-by: Jake Turner <jaketurner25@live.com>
Jakeeyturner added a commit to Jakeeyturner/blockchain-vscode-extension that referenced this issue Mar 17, 2020
@Jakeeyturner
Disable stop/restart on stopped local runtime from tree (close IBM-Bl…
f9aff4b 
…ockchain#1500)

Signed-off-by: Jake Turner <jaketurner25@live.com>
Jakeeyturner added a commit to Jakeeyturner/blockchain-vscode-extension that referenced this issue Mar 19, 2020
@Jakeeyturner
Only show actions depending if local environments are stopped/started (…
a5a7f03 
…close IBM-Blockchain#1500)

Signed-off-by: Jake Turner <jaketurner25@live.com>
Jakeeyturner added a commit to Jakeeyturner/blockchain-vscode-extension that referenced this issue Mar 19, 2020
@Jakeeyturner
Only show actions depending if local environments are stopped/started (…
b3f1687 
…close IBM-Blockchain#1500)

Signed-off-by: Jake Turner <jaketurner25@live.com>
Jakeeyturner added a commit to Jakeeyturner/blockchain-vscode-extension that referenced this issue Mar 20, 2020
@Jakeeyturner
Only show actions depending if local environments are stopped/started (…
1e261e2 
…close IBM-Blockchain#1500)

Signed-off-by: Jake Turner <jaketurner25@live.com>
Jakeeyturner added a commit to Jakeeyturner/blockchain-vscode-extension that referenced this issue Mar 20, 2020
@Jakeeyturner
Only show actions depending if local environments are stopped/started (…
7e08b66 
…close IBM-Blockchain#1500)

Signed-off-by: Jake Turner <jaketurner25@live.com>
@cazfletch
Copy link
Contributor

done so closing

Jakeeyturner added a commit to Jakeeyturner/blockchain-vscode-extension that referenced this issue Mar 31, 2020
@Jakeeyturner
Only show actions depending if local environments are stopped/started (…
b3a1079 
…close IBM-Blockchain#1500)

Signed-off-by: Jake Turner <jaketurner25@live.com>
Jakeeyturner added a commit to Jakeeyturner/blockchain-vscode-extension that referenced this issue Mar 31, 2020
@Jakeeyturner
Only show actions depending if local environments are stopped/started (…
fe5f450 
…close IBM-Blockchain#1500)

Signed-off-by: Jake Turner <jaketurner25@live.com>
cazfletch pushed a commit that referenced this issue Mar 31, 2020
@Jakeeyturner
Only show actions depending if local environments are stopped/started (…
cc9c4be 
…close #1500) (#2062)

Signed-off-by: Jake Turner <jaketurner25@live.com>
Jakeeyturner added a commit to Jakeeyturner/blockchain-vscode-extension that referenced this issue Mar 31, 2020
@Jakeeyturner
Only show actions depending if local environments are stopped/started (…
8a3bae5 
…close IBM-Blockchain#1500)

Signed-off-by: Jake Turner <jaketurner25@live.com>
@Jakeeyturner Jakeeyturner mentioned this issue Mar 31, 2020
Merged
au-shah pushed a commit to au-shah/blockchain-vscode-extension that referenced this issue Mar 31, 2020
@Jakeeyturner
Only show actions depending if local environments are stopped/started (…
3b5c87d 
…close IBM-Blockchain#1500) (IBM-Blockchain#2062)

Signed-off-by: Jake Turner <jaketurner25@live.com>
Jakeeyturner added a commit to Jakeeyturner/blockchain-vscode-extension that referenced this issue Apr 1, 2020
@Jakeeyturner
Only show actions depending if local environments are stopped/started (…
1d05ff7 
…close IBM-Blockchain#1500)

Signed-off-by: Jake Turner <jaketurner25@live.com>
@cazfletch cazfletch removed this from the Sprint 27 milestone Apr 1, 2020
@cazfletch cazfletch added this to the Sprint 28 milestone Apr 1, 2020
@cazfletch cazfletch added the next label Apr 1, 2020
Jakeeyturner added a commit to Jakeeyturner/blockchain-vscode-extension that referenced this issue Apr 3, 2020
@Jakeeyturner
Only show actions depending if local environments are stopped/started (…
1b4b131 
…close IBM-Blockchain#1500)

Signed-off-by: Jake Turner <jaketurner25@live.com>
cazfletch added a commit that referenced this issue Apr 3, 2020
@Jakeeyturner @cazfletch
Only show actions depending if local environments are stopped/started (…
6bf2216 
…close #1500) (#2111)

Signed-off-by: Jake Turner <jaketurner25@live.com>

Co-authored-by: Caroline Fletcher <cazfletch@gmail.com>
erin-hughes pushed a commit to erin-hughes/blockchain-vscode-extension that referenced this issue Apr 9, 2020
@Jakeeyturner @erin-hughes
Only show actions depending if local environments are stopped/started (…
9dff929 
…close IBM-Blockchain#1500) (IBM-Blockchain#2062)

Signed-off-by: Jake Turner <jaketurner25@live.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Jakeeyturner Jakeeyturner

Labels
bug Something isn't working sev3
Projects
None yet
Milestone
Sprint 28
Development

No branches or pull requests
2 participants
@Jakeeyturner @cazfletch