Skip to content
This repository has been archived by the owner on Jan 31, 2023. It is now read-only.

After importing nodes to existing environment, should only refresh if already connected to environment #1762

Closed
lquintai opened this issue Dec 12, 2019 · 0 comments · Fixed by #1771
Closed

After importing nodes to existing environment, should only refresh if already connected to environment #1762

lquintai opened this issue Dec 12, 2019 · 0 comments · Fixed by #1771
Assignees
@cazfletch
Labels
bug Something isn't working
Milestone
Sprint 23

Comments

@lquintai
Copy link
Contributor

Current code will always connect after importing nodes to an existing environment, because fromAddEnvironment will always be false and at that point environmentRegistryEntry will always exist:

    if (!fromAddEnvironment && environmentRegistryEntry) {
        // only do this if we run the command from the tree as need to refresh the tree to do setup
        await vscode.commands.executeCommand(ExtensionCommands.CONNECT_TO_ENVIRONMENT, environmentRegistryEntry);
    }

We should only be refreshing if we are connected to the environment we want to refresh.
@lquintai lquintai added the bug Something isn't working label Dec 12, 2019
@cazfletch cazfletch added the next label Dec 12, 2019
@cazfletch cazfletch added this to the Sprint 23 milestone Dec 12, 2019
@cazfletch cazfletch self-assigned this Dec 12, 2019
@cazfletch cazfletch mentioned this issue Dec 16, 2019
Merged
cazfletch added a commit that referenced this issue Dec 27, 2019
@cazfletch @Jakeeyturner
Fix refreshing environment review when import nodes (#1771)
ac45784 
Updated so that the environment view will only refresh if you update the environment you are connected to

closes #1762

Signed-off-by: Caroline Fletcher <cazfletch@gmail.com>

Co-authored-by: Jake <Jakeeyturner@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cazfletch cazfletch

Labels
bug Something isn't working
Projects
None yet
Milestone
Sprint 23
Development

Successfully merging a pull request may close this issue.

Fix refreshing environment review when import nodes
2 participants
@cazfletch @lquintai