This repository has been archived by the owner on Jan 31, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…date the version numbering! Signed-off-by: Ed Peter John Moffatt <prion.son.ed@gmail.com>
…-vscode-extension into tutorial1update
Reviewed by MGK and he's happy! So removing the [DO NOT MERGE] |
cazfletch
suggested changes
Jan 8, 2020
|
||
4. The extension will ask you if you want to name the asset in the generated contract. This will default to `MyAsset`, but you're welcome to have some fun ;) What do you intend to use your blockchain for? This will determine what type of asset you create, update and read from the ledger: `Radish`? `Pineapple`? `Penguin`? Pick whatever you like! For the sake of this tutorial, we'll be boring and stick with `MyAsset`. | ||
4. The extension will ask you if you want to name the asset in the generated contract. This will default to `MyAsset`, but you're welcome to change it. What do you intend to use your blockchain for? This will determine what type of asset you create, update and read from the ledger: `Radish`? `Pineapple`? `Penguin`? Pick whatever you like! For the sake of this tutorial, we'll be boring and stick with `MyAsset`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we take out the word sake
|
||
Click that message and the extension will start spinning up Docker containers for you. The message "Local Fabric runtime is starting..." will appear, with a loading spinner, and when the task is complete you will see a set of expandable/collapsible sections labelled `Smart Contracts`, `Channels`, `Nodes` and `Organizations`. | ||
Using this extension, developers can complete all 3 steps in a single action (on a simple environment like _Local Fabric_). Alternatively, you could perform each step individually - this is a little slower, but may help you understand the steps better. We'll _instantiate_ the contract using the "1-step method", them make a small change and _upgrade_ it using the "3-step method" - once you've tried both, you can pick which one you prefer to use going forward. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
them make a small change
should be then make a small change
Signed-off-by: Ed Peter John Moffatt <prion.son.ed@gmail.com>
…-vscode-extension into tutorial1update
EdMoffatt
force-pushed
the
tutorial1update
branch
from
January 8, 2020 11:28
40dfebf
to
4f88944
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
cazfletch
approved these changes
Jan 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please don't merge just yet, I'm gonna send this over to MGK for a review first!