This repository has been archived by the owner on Jan 31, 2023. It is now read-only.
[DO NOT MERGE] Delete smart contracts package #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cazfletch
suggested changes
Sep 7, 2018
client/src/commands/commandsUtil.ts
Outdated
| static async showSmartContractPackagesQuickPickBox(prompt: string): Promise<string | undefined> { | ||
| const blockchainPackageExplorerProvider = myExtension.getBlockchainPackageExplorerProvider(); | ||
|
|
||
| const projects: Array<PackageTreeItem> = await blockchainPackageExplorerProvider.getChildren(); |
There was a problem hiding this comment.
This should be calling your new function
client/src/commands/commandsUtil.ts
Outdated
| placeHolder: prompt | ||
| }; | ||
|
|
||
| const projectNames = []; |
| } | ||
|
|
||
| const blockchainPackageExplorerProvider = myExtension.getBlockchainPackageExplorerProvider(); | ||
| const packages: Array<PackageTreeItem> = await blockchainPackageExplorerProvider.getChildren(); |
There was a problem hiding this comment.
This shouldn't be calling this it should use the new function
| vscode.window.showErrorMessage('Issue reading smart contract package folder:' + this.packageDir); | ||
| return; | ||
| } | ||
| } | ||
| this.tree = await this.createPackageTree(this.packageArray as Array<PackageTreeItem>); |
There was a problem hiding this comment.
this.packageArray isn't an array of packageTreeItems
client/src/util/CommandUtil.ts
Outdated
| import * as child_process from 'child_process'; | ||
| import stripAnsi = require('strip-ansi'); | ||
|
|
||
| import * as childProcessPromise from 'child-process-promise'; | ||
| import { ConsoleOutputAdapter } from '../logging/ConsoleOutputAdapter'; | ||
| import { OutputAdapter } from '../logging/OutputAdapter'; | ||
| import * as fs from 'fs-extra'; | ||
| import * as homeDir from 'home-dir'; | ||
| import { PackageTreeItem } from '../explorer/model/PackageTreeItem'; |
There was a problem hiding this comment.
This isn't used, if it is and i'm blind you shouldn't be creating packageTreeItems in here it should do this in the packageProvider
| @@ -126,4 +128,28 @@ describe('Commands Utility Function Tests', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| describe('getPackages', () => { | |||
| // Should move and rewrite aspects of 'getChildren' tests from blockchainPackageExplorer and move them here. | |||
There was a problem hiding this comment.
do you still need this comment?
Jakeeyturner
commented
Sep 10, 2018
| await fs.remove(packageDir + '/' + packages[index].name); | ||
|
|
||
| } | ||
| return blockchainPackageExplorerProvider.refresh(); |
There was a problem hiding this comment.
this should call the refresh command eg vscode.commands.execute('blockchainAPackageExplorer.refreshEntry')
Jakeeyturner
force-pushed
the
issue-9-rebase2
branch
5 times, most recently
from
1f901e8
to
0b3ae63
Compare
cazfletch
suggested changes
Sep 10, 2018
| packageToDelete = await UserInputUtil.showSmartContractPackagesQuickPickBox('Choose the smart contract package that you want to delete'); | ||
| } | ||
|
|
||
| const packages: any[] = await CommandUtil.getPackages(); |
There was a problem hiding this comment.
is the type string here if so we should change it to be string
client/src/util/CommandUtil.ts
Outdated
|
|
||
| public static async getPackages(): Promise<string[]> { | ||
| console.log('CommandUtils: getPackages'); | ||
| let packageArray: Array<any> = []; |
There was a problem hiding this comment.
this is an array of strings
Jakeeyturner
force-pushed
the
issue-9-rebase2
branch
from
0b3ae63
to
c474908
Compare
Jakeeyturner
force-pushed
the
issue-9-rebase2
branch
from
c474908
to
11d8670
Compare
Jakeeyturner
force-pushed
the
issue-9-rebase2
branch
from
11d8670
to
40d75d6
Compare
Jakeeyturner
force-pushed
the
issue-9-rebase2
branch
from
40d75d6
to
e96b18d
Compare
Closes IBM-Blockchain#9 Signed-off-by: Jakeeyturner <jaketurner25@live.com>
Jakeeyturner
force-pushed
the
issue-9-rebase2
branch
from
e96b18d
to
1af57f4
Compare
Jakeeyturner
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9
Signed-off-by: Jakeeyturner jaketurner25@live.com