Skip to content
This repository has been archived by the owner on Jan 31, 2023. It is now read-only.

Separate client and runtime connections (contributes to #776) #785

Merged

Conversation

sstone1
Copy link
Contributor

@sstone1 sstone1 commented Mar 29, 2019

The work for #776 requires that the runtime connection and runtime ops view works very differently to how it works today, so the time has come to split client and runtime connections apart.

This is the first stage of the changes where we simply separate the interfaces and make sure the right code is using the right one. Further changes will come where the methods on each interface are cut down, and common code moved into the right place.

  • Split IFabricConnection into IFabricClientConnection and IFabricRuntimeConnection
  • Gateway tasks (submit, evaluate, generate tests, etc) use IFabricClientConnection
  • Ops tasks (install, instantiate, upgrade, etc) use IFabricRuntimeConnection
  • Update the connect command to always use IFabricClientConnection, even when connecting to the local Fabric

I started off with this change, then found that we need to do this and backed it out:

  • Update the create identity command to use the runtime managers connection object, not create its own each time

This is because we have to switch to the admin identity, instead of the Admin@org1.example.com identity, in order to perform CA operations. Will remove that later when the admin identity can be used everywhere!

Signed-off-by: Simon Stone sstone1@uk.ibm.com

@sstone1 sstone1 self-assigned this Mar 29, 2019
…n#776)

Signed-off-by: Simon Stone <sstone1@uk.ibm.com>
@sstone1 sstone1 force-pushed the issue-776-split-connections branch from 2ad5f76 to 59eed86 Compare March 29, 2019 16:39
@sstone1 sstone1 requested a review from cazfletch April 1, 2019 07:54
Copy link
Contributor

@cazfletch cazfletch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cazfletch cazfletch merged commit 7f1508a into IBM-Blockchain:wallet-524 Apr 1, 2019
@sstone1 sstone1 deleted the issue-776-split-connections branch April 1, 2019 08:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants