Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ibm_pi_instance_info is not showing decimal places for CPUs #3053

Closed
cunlifs opened this issue Sep 2, 2021 · 3 comments · Fixed by #3054
Closed

ibm_pi_instance_info is not showing decimal places for CPUs #3053

cunlifs opened this issue Sep 2, 2021 · 3 comments · Fixed by #3054
Assignees
Labels
service/Power Systems Issues related to Power Systems

Comments

@cunlifs
Copy link

cunlifs commented Sep 2, 2021

Using:
Terraform v1.0.3 on linux_ppc64le & terraform-provider-ibm_v1.28.0

When I run the ibm.cloudcollection.ibm_pi_instance_info modules against a PVS VSI it only returns the unit information about the min/current and max entitled cores. In PVS this number can be a fraction of a whole core, from 0.25. Max is 2 decimal points. For example a VSI with 0.25 cores is showing as 0.

pi_instance_existing_output”: {
“changed”: false,
“resource”: {
…..
“minproc”: 0,
“pi_cloud_instance_id”: “dd5a404f-59cb-4c04-b9a0-811b47c6df19",
“pi_instance_name”: “stu-test2",
“pin_policy”: “none”,
“processors”: 0,

Info from @jaywcarman:
Terraform provider is calling them out as integers:
https://registry.terraform.io/providers/IBM-Cloud/ibm/latest/docs/data-sources/pi_instance#attribute-reference

But it's easy to show that's not the case:

ic pi in 00140962-1c1d-4256-93b7-3f8f4ff836c1 --json | jq .minproc
0.25


Can this be looked at please as I'm hoping its a simple fix.

@hkantare hkantare added the service/Power Systems Issues related to Power Systems label Sep 2, 2021
@jwcroppe
Copy link
Collaborator

jwcroppe commented Sep 2, 2021

@yussufsh FYI

@yussufsh
Copy link
Collaborator

yussufsh commented Sep 2, 2021

We need to also look at other attributes where the types needs to be corrected and also the website page need some updates. I will work on the fix.

@jwcroppe jwcroppe assigned yussufsh and unassigned jwcroppe Sep 2, 2021
@jwcroppe
Copy link
Collaborator

jwcroppe commented Sep 2, 2021

Thanks @yussufsh - agree - we should also clarify the documentation as well with some examples of the various data types so that it's clear what each attribute represents.

yussufsh added a commit to yussufsh/terraform-provider-ibm that referenced this issue Sep 2, 2021
Fixes IBM-Cloud#3053

Signed-off-by: Yussuf Shaikh <yussuf.shaikh@ibm.com>
hkantare pushed a commit that referenced this issue Sep 6, 2021
Fixes #3053

Signed-off-by: Yussuf Shaikh <yussuf.shaikh@ibm.com>
kavya498 pushed a commit to kavya498/terraform-provider-ibm that referenced this issue Sep 30, 2021
Fixes IBM-Cloud#3053

Signed-off-by: Yussuf Shaikh <yussuf.shaikh@ibm.com>
kavya498 pushed a commit to kavya498/terraform-provider-ibm that referenced this issue Sep 30, 2021
Fixes IBM-Cloud#3053

Signed-off-by: Yussuf Shaikh <yussuf.shaikh@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service/Power Systems Issues related to Power Systems
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants