Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump cr SDK version, hygiene and br-sao support #3258

Merged
merged 1 commit into from
Nov 8, 2021

Conversation

jhart1685
Copy link
Contributor

Signed-off-by: James Hart jhart@uk.ibm.com

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Updates the container-registry-go-sdk dependency to 0.0.14. This is partially a hygiene update, but also adds support for the br.icr.io registry instance in br-sao.
I've also updated the pre-commit hook config and secrets baseline to use the latest version of the detect-secrets tool.

Output from acceptance testing:

$ make testacc TEST=./ibm TESTARGS='-run="TestAccIBMCr.*"'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./ibm -v -run="TestAccIBMCr.*" -timeout 700m
............
=== RUN   TestAccIBMCrNamespacesDataSourceBasic
--- PASS: TestAccIBMCrNamespacesDataSourceBasic (37.85s)
=== RUN   TestAccIBMCrNamespaceBasic
--- PASS: TestAccIBMCrNamespaceBasic (60.14s)
=== RUN   TestAccIBMCrNamespaceAllArgs
--- PASS: TestAccIBMCrNamespaceAllArgs (63.54s)
=== RUN   TestAccIBMCrRetentionPolicyAllArgs
--- PASS: TestAccIBMCrRetentionPolicyAllArgs (50.39s)
PASS

Signed-off-by: James Hart <jhart@uk.ibm.com>
@hkantare hkantare merged commit 2a55d70 into IBM-Cloud:master Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants