CIS CNAME Setup : Create Partial Zone #3937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arpit-srivastava-ibm
changed the title
|
Added new Test case - |
hkantare
reviewed
Jul 29, 2022
| @@ -28,6 +28,12 @@ func DataSourceIBMCISDomain() *schema.Resource { | |||
| Description: "CISzone - Domain", | |||
| Required: true, | |||
| }, | |||
| cisDomainType: { | |||
There was a problem hiding this comment.
In datasource its a conputed not optional with default
There was a problem hiding this comment.
Corrected this
| @@ -40,6 +53,10 @@ In addition to all argument reference list, you can access the following attribu | |||
| - `original_name_servers` - (String) The name servers that were used when the domain was first registered with the DNS Registrar. | |||
| - `paused`- (Bool) Indicates if the domain is paused and network traffic bypasses your IBM Cloud Internet Services instance. The default values is **false**. | |||
| - `status` - (String) The status of the domain. Valid values are `active`, `pending`, `initializing`, `moved`, `deleted`, and `deactivated`. After creation, the status remains pending until the DNS Registrar is updated with the CIS name servers, exported in the `name_servers` variable. | |||
| - `type` - (String) The type of domain to be created. Default value is noted to be `full`- for regular domains, & to create a partial domain for CNAME setup, value to be used is `partial`. | |||
There was a problem hiding this comment.
Type is optional varaible it should be added under Argument Reference.
Add the doc changes for datasoruce also
| Type: schema.TypeString, | ||
| Description: "CISzone - Domain Type", | ||
| Default: "full", | ||
| Optional: true, |
There was a problem hiding this comment.
Add validator funciton to allow only "full", "partial"
hkantare
reviewed
Aug 9, 2022
| @@ -0,0 +1,10 @@ | |||
| # This file is maintained automatically by "terraform init". | |||
There was a problem hiding this comment.
you need this myExample folder also?
SunithaGudisagarIBM
pushed a commit
to ibm-vpc/terraform-provider-ibm
that referenced
this pull request
Sep 14, 2022
* update the action based on hashicorp/ghaction-import-gpg#11 * CIS CNAME Setup : Create Partial Zone * addressed comments * added validator * removed conflict * removed unused folder Co-authored-by: hkantare <hkantare@in.ibm.com> Co-authored-by: Arpit Srivastava <arpit-mac@Arpits-MacBook-Pro.local>
SunithaGudisagarIBM
pushed a commit
to ibm-vpc/terraform-provider-ibm
that referenced
this pull request
Sep 14, 2022
* update the action based on hashicorp/ghaction-import-gpg#11 * CIS CNAME Setup : Create Partial Zone * addressed comments * added validator * removed conflict * removed unused folder Co-authored-by: hkantare <hkantare@in.ibm.com> Co-authored-by: Arpit Srivastava <arpit-mac@Arpits-MacBook-Pro.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CIS CNAME Setup -
verification_key&cname_suffix