fix(IAM Policy Management): Added nest conditions to rule.conditions #4896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shaun Colley <shaun.colley@ibm.com>
Signed-off-by: Shaun Colley <shaun.colley@ibm.com>
…der-ibm into nestedPolicyConditions
Signed-off-by: Shaun Colley <shaun.colley@ibm.com>
|
Latest tests for sanity check of change and actually validating impacted code: $ make testacc TESTARGS='TestAccIBMIAMUserPolicy'
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/iampolicy 819.397s$ make testacc TESTARGS='TestAccIBMIAMPolicyTemplate'
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/iampolicy 220.462s$ make testacc TESTARGS='TestAccIBMIAMAccessGroupPolicy'
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/iampolicy 1223.861s$ make testacc TESTARGS='TestAccIBMIAMPolicyAssignments'
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/iampolicy 20.980s$ make testacc TESTARGS='TestAccIBMIAMTrustedProfilePolicy'
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/iampolicy 1139.571s$ make testacc TESTARGS='TestAccIBMIAMServicePolicy'
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/iampolicy 1180.860sOnce go sdk is merged, I will update terraform PR. |
Signed-off-by: Shaun Colley <shaun.colley@ibm.com>
|
tests from latest minor change: go test ./ibm/service/iampolicy/ -run=TestAccIBMIAMUserPolicy_With_Attribute_Based_Condition -timeout 700m
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/iampolicy 58.224s
go test ./ibm/service/iampolicy/ -run=TestAccIBMIAMAccessGroupPolicy -timeout 700m
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/iampolicy 1338.534s
go test ./ibm/service/iampolicy/ -run=TestAccIBMIAMPolicyTemplate -timeout 700m
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/iampolicy 236.485s |
Signed-off-by: Shaun Colley <shaun.colley@ibm.com>
|
Latest tests verifying new go.mod / go.sum: go test ./ibm/service/iampolicy/ -run=TestAccIBMIAMUserPolicy_With_Attribute_Based_Condition -timeout 700m
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/iampolicy 55.617s
shaunsmacibm@Shauns-MacBook-Pro terraform-provider-ibm % go test ./ibm/service/iampolicy/ -run=TestAccIBMIAMAccessGroupPolicy -timeout 700m
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/iampolicy 1223.958s |
Signed-off-by: Shaun Colley <shaun.colley@ibm.com>
hkantare
approved these changes
Nov 10, 2023
|
Can you resolve conflcits |
swcolley
force-pushed
the
nestedPolicyConditions
branch
from
356e8ae
to
c1a91d6
Compare
|
I had to update merge from master because go.sum was not properly resolved. |
swcolley
force-pushed
the
nestedPolicyConditions
branch
from
c1a91d6
to
1eeab24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Relates OR Closes https://github.ibm.com/IAM/AM-issues/issues/1908
NOTE: This PR needs newest release from SDK and updated go.mod and go.sum prior to merging:
IBM/platform-services-go-sdk#285
Output from acceptance testing:
User policy:
$ make testacc TESTARGS='TestAccIBMIAMUserPolicy' ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/iampolicy 564.903sAccess Group Policy:
Trusted Profile Policy:
$ make testacc TESTARGS='TestAccIBMIAMTrustedProfilePolicy' ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/iampolicy 1109.446sService Policy:
$ make testacc TESTARGS='TestAccIBMIAMServicePolicy' ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/iampolicy 844.938sPolicy Templates:
$ make testacc TESTARGS='TestAccIBMIAMPolicyTemplate' PASS ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/iampolicy 194.897sPolicy Assignments:
$ make testacc TESTARGS='TestAccIBMIAMPolicyAssignments' ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/iampolicy 19.604s