Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(IAM Policy Management): Added nest conditions to rule.conditions #285

Merged
merged 2 commits into from
Oct 31, 2023
Merged

fix(IAM Policy Management): Added nest conditions to rule.conditions #285

merged 2 commits into from
Oct 31, 2023

Conversation

swcolley
Copy link
Contributor

PR summary

Updated based on API definition fix to allow for conditions under rule.conditions.
Tests:

Examples:

go test -tags=examples
Ran 213 of 213 Specs in 13.890 seconds
SUCCESS! -- 213 Passed | 0 Failed | 0 Pending | 0 Skipped
PASS
ok  	github.com/IBM/platform-services-go-sdk/iampolicymanagementv1	14.331s

Integration:

go test -tags=integration
Ran 211 of 211 Specs in 21.518 seconds
SUCCESS! -- 211 Passed | 0 Failed | 0 Pending | 0 Skipped
PASS
ok  	github.com/IBM/platform-services-go-sdk/iampolicymanagementv1	22.384s

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Updates Rule to allow for properties that are already allowed for in API.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

issue: https://github.ibm.com/IAM/AM-issues/issues/1908

@swcolley
fix(IAM Policy Management): Added nest conditions to rule.conditions
36e7e4d 
Signed-off-by: Shaun Colley <shaun.colley@ibm.com>
@swcolley
fix(IAM Policy Management): Updated condition based on api definition
f87c65c 
Signed-off-by: Shaun Colley <shaun.colley@ibm.com>
@padamstx padamstx self-requested a review October 30, 2023 16:08
@padamstx padamstx self-assigned this Oct 30, 2023
padamstx
padamstx approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; will wait for the other PRs before merging.

iampolicymanagementv1/iam_policy_management_v1.go
@@ -15,7 +15,7 @@
*/

/*
* IBM OpenAPI SDK Code Generator Version: 3.78.0-67aec9b7-20230818-174940
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a problem with this PR, but think about installing the latest generator version prior to your next PR :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you. Will do!

@swcolley swcolley mentioned this pull request Oct 31, 2023
Merged
@padamstx padamstx merged commit df59e07 into main Oct 31, 2023
4 checks passed
@padamstx padamstx deleted the policyNestedConditions branch October 31, 2023 16:45
ibm-devx-sdk pushed a commit that referenced this pull request Oct 31, 2023
@semantic-release-bot
chore(release): 0.52.1 release notes [skip ci]
2689328 
## [0.52.1](v0.52.0...v0.52.1) (2023-10-31)

### Bug Fixes

* **IAM Policy Management:** add nested conditions to rule.conditions ([#285](#285)) ([df59e07](df59e07))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.52.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@padamstx padamstx padamstx approved these changes

Assignees

@padamstx padamstx

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@swcolley @ibm-devx-sdk @padamstx