-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Add keyboard layout support to bastion kickstart template #132
Fix: Add keyboard layout support to bastion kickstart template #132
Conversation
@smolin-de Can you pls review this little PR. Thx. |
|
Test for create bastion: PLAY RECAP ******************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************** On bastion: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see my comments
Signed-off-by: Amadeuds Podvratnik <pod@de.ibm.com>
Co-authored-by: Klaus Smolin <88041391+smolin-de@users.noreply.github.com> Signed-off-by: Amadeuds Podvratnik <pod@de.ibm.com>
Signed-off-by: Amadeuds Podvratnik <pod@de.ibm.com>
a409021
to
b6e5ff1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
🎉 This PR is included in version 1.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
signed-off-by: Amadeuds Podvratnik [pod@de.ibm.com](mailto:pod@de.ibm.com) This fix adds support for the keyboard layout to the kickstart file to the create bastion playbook. --------- Signed-off-by: Amadeuds Podvratnik <pod@de.ibm.com> Co-authored-by: Klaus Smolin <88041391+smolin-de@users.noreply.github.com> Co-authored-by: Jacob Emery <jacob.emery@ibm.com>
signed-off-by: Amadeuds Podvratnik pod@de.ibm.com
This fix adds support for the keyboard layout to the kickstart file to the create bastion playbook.