Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Add keyboard layout support to bastion kickstart template #132

Merged
merged 5 commits into from
May 22, 2023
Merged

Fix: Add keyboard layout support to bastion kickstart template #132

merged 5 commits into from
May 22, 2023

Conversation

AmadeusPodvratnik
Copy link
Collaborator

@AmadeusPodvratnik AmadeusPodvratnik commented May 11, 2023 •
edited
Loading

signed-off-by: Amadeuds Podvratnik pod@de.ibm.com

This fix adds support for the keyboard layout to the kickstart file to the create bastion playbook.

@AmadeusPodvratnik
Copy link
Collaborator Author

@smolin-de Can you pls review this little PR. Thx.

@AmadeusPodvratnik AmadeusPodvratnik added the bug Something isn't working label May 11, 2023
@AmadeusPodvratnik AmadeusPodvratnik mentioned this pull request May 11, 2023
Closed
@smolin-de
Copy link
Contributor

smolin-de commented May 12, 2023 •
edited
Loading

@smolin-de Can you pls review this little PR. Thx.
Additional comments:

  1. The commit message should start with "fix:".
  2. The commit message body looks strange. It tsrats with "Test for create bastion:
    TASK [create_bastion : Waiting 1...."

@AmadeusPodvratnik AmadeusPodvratnik changed the title Add keyboard layout support to bastion kickstart template Fix: Add keyboard layout support to bastion kickstart template May 12, 2023
@AmadeusPodvratnik
Copy link
Collaborator Author

AmadeusPodvratnik commented May 12, 2023 •
edited
Loading

Test for create bastion:
TASK [create_bastion : Waiting 1 minute for automated bastion installation and configuration to complete] *********************************************************************************************************************************************************************************************************************************************************************************************
Pausing for 60 seconds
(ctrl+C then 'C' = continue early, ctrl+C then 'A' = abort)
ok: [a314lp34] => {"changed": false, "delta": 60, "echo": true, "rc": 0, "start": "2023-05-11 11:24:11.590973", "stderr": "", "stdout": "Paused for 1.0 minutes", "stop": "2023-05-11 11:25:11.593587", "user_input": ""}

PLAY RECAP ********************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************

On bastion:
[root@bastion-ocpz ~]# cat /etc/vconsole.conf
KEYMAP="de"
FONT="eurlatgr"
a314lp34 : ok=11 changed=7 unreachable=0 failed=0 skipped=0 rescued=0 ignored=0

smolin-de
smolin-de reviewed May 12, 2023
View reviewed changes
Copy link
Contributor

@smolin-de smolin-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comments

inventories/default/group_vars/all.yaml.template Show resolved Hide resolved
AmadeusPodvratnik and others added 3 commits May 15, 2023 11:22
@AmadeusPodvratnik
Add keyboard layout support to bastion kickstart template
5f15463 
Signed-off-by: Amadeuds Podvratnik <pod@de.ibm.com>
@AmadeusPodvratnik @smolin-de
Update docs/set-variables-group-vars.md
38f63db 
Co-authored-by: Klaus Smolin <88041391+smolin-de@users.noreply.github.com>
Signed-off-by: Amadeuds Podvratnik <pod@de.ibm.com>
@AmadeusPodvratnik
Fix typos in doc.
b6e5ff1 
Signed-off-by: Amadeuds Podvratnik <pod@de.ibm.com>
jacobemery
jacobemery approved these changes May 22, 2023
View reviewed changes
Copy link
Collaborator

@jacobemery jacobemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jacobemery jacobemery merged commit bcb6874 into IBM:main May 22, 2023
1 check passed
@AmadeusPodvratnik
Copy link
Collaborator Author

🎉 This PR is included in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

jacobemery added a commit that referenced this pull request Dec 20, 2023
@AmadeusPodvratnik @smolin-de @jacobemery
Fix: Add keyboard layout support to bastion kickstart template (#132)
2730123 
signed-off-by: Amadeuds Podvratnik
[pod@de.ibm.com](mailto:pod@de.ibm.com)

This fix adds support for the keyboard layout to the kickstart file to
the create bastion playbook.

---------

Signed-off-by: Amadeuds Podvratnik <pod@de.ibm.com>
Co-authored-by: Klaus Smolin <88041391+smolin-de@users.noreply.github.com>
Co-authored-by: Jacob Emery <jacob.emery@ibm.com>
@AmadeusPodvratnik AmadeusPodvratnik deleted the add_keyboard_layout_support branch March 6, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobemery jacobemery jacobemery approved these changes

@smolin-de smolin-de smolin-de approved these changes

Assignees
No one assigned
Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AmadeusPodvratnik @smolin-de @jacobemery