Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing identifier modifier in FHIRParameters.Modifier enum #2427

Closed
csandersdev opened this issue May 25, 2021 · 6 comments
Closed

Missing identifier modifier in FHIRParameters.Modifier enum #2427

csandersdev opened this issue May 25, 2021 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@csandersdev
Copy link
Contributor

Describe the bug
The conformance guide says that we support the Reference :identifier modifier, but it is not declared in the fhir-client module FHIRParameters.Modifier enum.

Environment
4.8.1

To Reproduce
Steps to reproduce the behavior:

  1. View the code for the FHIRParameters.Modifier enum and note that identifier is missing.

Expected behavior
All supported modifiers are declared in the enum.

@csandersdev csandersdev added the bug Something isn't working label May 25, 2021
@csandersdev
Copy link
Contributor Author

csandersdev commented May 25, 2021

Something else to consider here is the value/utility of the TYPE member of the FHIRParameters.Modifier enum. If I'm writing client code and I want to filter on a specific type new FHIRParameters().searchParam( "subject", Modifier.TYPE, "23" ) isn't going to spit out what I want. It would be more useful to the client to have the ResourceTypes available as modifiers or specifiable in the searchParam method signature.

@csandersdev
Copy link
Contributor Author

One more thought on FHIRParameters is that reference chaining is not well supported in the FHIRParameters class right now. If I wanted to do /Observation?subject:Patient.name=peter, I would have to construct that myself in the name of the query parameter vs. having the client construct it for me.

@csandersdev
Copy link
Contributor Author

Looks like we are also missing the "of-type" modifier for token.

@tbieste tbieste self-assigned this May 26, 2021
@tbieste tbieste added this to the Sprint 2021-07 milestone May 26, 2021
tbieste added a commit that referenced this issue May 26, 2021
Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
tbieste added a commit that referenced this issue May 26, 2021
Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
tbieste added a commit that referenced this issue May 27, 2021
Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
@csandersdev
Copy link
Contributor Author

This covers most of what I mentioned above, but do we want to do anything in this PR around my third comment above regarding reference chaining? I'd be happy to split that into a separate issue if the team wants to handle that separately.

@tbieste
Copy link
Contributor

tbieste commented May 28, 2021

This covers most of what I mentioned above, but do we want to do anything in this PR around my third comment above regarding reference chaining? I'd be happy to split that into a separate issue if the team wants to handle that separately.

Yeah, I prefer to keep things close to the original bug; to avoid feature creep in work items. If this satisfies the original bug, then opening a separate issue for the item in your third comment sounds good to me.

tbieste added a commit that referenced this issue Jun 2, 2021
Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
tbieste added a commit that referenced this issue Jun 2, 2021
Issue #2427 - Add missing modifiers to FHIRParameters in FHIR Client
@lmsurpre
Copy link
Member

lmsurpre commented Jun 3, 2021

Confirmed that the new prefixes were added to the enums and that the new :[type] modifier methods have unit test coverage.

@lmsurpre lmsurpre closed this as completed Jun 3, 2021
tbieste added a commit that referenced this issue Jun 9, 2021
Issue #2427 - Add missing modifiers to FHIRParameters in FHIR Client
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants