Temporary fix for CI with k8s 1.9.4 #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do not merge yet until the Travis CI passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minikube updated its Kubernetes Version to 1.9.4 yesterday and it made the Travis failed.
Kubernetes 1.9.4 changes secret, configMap, downwardAPI and projected volumes to mount read-only which cause our current learner implementation to be failed. Adding the feature gate
ReadOnlyAPIDataVolumes=falsewill temporary resolve this issue in CI. Since the community said is not a good practice to let a pod to modify mounted secret, configMap, downwardAPI and projected volumes, we should change our learner implementation during our next sync.