This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
add bandit #33
Merged
add bandit #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuhdev
reviewed
May 26, 2020
maxfw/utils/image_utils.py
Outdated
| assert sum(encoding[:-1]) == 0, \ | ||
| 'A Standardize or Normalize transformation must be positioned at the end of the pipeline.' | ||
| if sum(encoding[:-1]) != 0: | ||
| raise ValueError('A Standardize or Normalize transformation must be positioned at the end of the pipeline.') |
There was a problem hiding this comment.
Suggested change
| raise ValueError('A Standardize or Normalize transformation must be positioned at the end of the pipeline.') | |
| raise ValueError('A Standardize or Normalize transformation can only be positioned at the end of the pipeline.') |
There was a problem hiding this comment.
Maybe another if-clause for encoding[-1]?
There was a problem hiding this comment.
@xuhdev something like this:
if sum(encoding[:-1]) != 0 or encoding[-1]:?
There was a problem hiding this comment.
Yes, but the error message would be hard to write if done in one if-clause
There was a problem hiding this comment.
Is this being caught here?
https://github.com/IBM/MAX-Framework/blob/master/maxfw/core/utils.py#L38
There was a problem hiding this comment.
Don't look like the same thing to me, maybe @djalova can confirm?
There was a problem hiding this comment.
I think it's better to ask @kmh4321
Co-authored-by: Hong Xu <hong@topbug.net>
Co-authored-by: Brendan Dwyer <brendan.dwyer@ibm.com>
Co-authored-by: Brendan Dwyer <brendan.dwyer@ibm.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
banditsecurity checksbanditflask-restplustoflask-restx