fix(pagination): correct labelling discrepancies between versions #1417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshblack
suggested changes
Nov 9, 2018
| @@ -2,9 +2,9 @@ | |||
| <div class="bx--pagination__left"> | |||
| <div class="bx--select{{#is version "v2"}} bx--select--inline{{/is}}"> | |||
| {{#is version "v2"}} | |||
| <label for="select-id-pagination" class="bx--pagination__text">Items per page: </label> | |||
| <label for="items-per-page" class="bx--pagination__text">Items per page: </label> | |||
There was a problem hiding this comment.
Is this the correct label? <label> content should be the same as aria-label for select if we are using the for attribute, I thought? Let me know if I'm off here 🤔
There was a problem hiding this comment.
Totally adding redundancy here, you're right. There's only an implicit label in version 2, so the added aria-label is DAP errors in other versions.
alisonjoseph
approved these changes
Nov 13, 2018
joshblack
approved these changes
Nov 15, 2018
|
🎉 This PR is included in version 9.53.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
joshblack
pushed a commit
to joshblack/carbon
that referenced
this pull request
May 2, 2019
…system#1417) * fix: Add listener to outside of modal. * fix: Update focus ref. * fix: Change ref naming to more closely mimic the Modal component.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1362
Fixes up some discrepancies between the two different versions of pagination causing labels to be applied incorrectly.