fix(search): AVT1 bugs #1416
Merged
fix(search): AVT1 bugs #1416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asudoh
approved these changes
Nov 9, 2018
joshblack
suggested changes
Nov 9, 2018
src/components/search/search.hbs
Outdated
| <label id="search-input-label-1" class="bx--label" for="search__input-1">Search</label> | ||
| <input class="bx--search-input" type="text" role="search" id="search__input-1" placeholder="Search" aria-labelledby="search-input-label-2"> | ||
| <input class="bx--search-input" type="text" id="search__input-1" placeholder="Search" aria-labelledby="search-input-label-1"> |
There was a problem hiding this comment.
This is more-so an issue with the originally markup, but why do we have label with for and aria-labelledby set?
There was a problem hiding this comment.
Totally. Took it out. 👍
|
🎉 This PR is included in version 9.48.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
joshblack
pushed a commit
to joshblack/carbon
that referenced
this pull request
May 2, 2019
…system#1417) * fix: Add listener to outside of modal. * fix: Update focus ref. * fix: Change ref naming to more closely mimic the Modal component.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1363
Implements various changes to address AVT1 bugs found in the search component during testing.