Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup include directory #2

Merged
merged 5 commits into from
Feb 21, 2018
Merged

Cleanup include directory #2

merged 5 commits into from
Feb 21, 2018

Conversation

fengggli
Copy link
Collaborator

Changes:

  1. since there is a "common" mk/common.cmake:
  • It's sufficient to include this file is only once in the top level CMakeLists.txt
  • removed redundant include_directories in subdirectories(the included dirs in top-level is visible to all sub directories)

Suggestions/TODO:

  1. Perhaps also remove the redundant link_directories

@dwaddington dwaddington merged commit 555c079 into IBM:unstable Feb 21, 2018
@fengggli fengggli deleted the cleanup branch February 22, 2018 15:05
@dwaddington dwaddington mentioned this pull request Dec 4, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fengggli @dwaddington